Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async: support IPv6 QoS. #13418

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
5 participants
@robbat2
Copy link
Contributor

robbat2 commented Feb 14, 2017

Extend DSCP marking for heartbeat packets to IPv6.

Backport: jewel, luminious
See-Also: http://tracker.ceph.com/issues/18887
Fixes: http://tracker.ceph.com/issues/18928
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com

@tchaikov
Copy link
Contributor

tchaikov left a comment

/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/PosixStack.cc: In member function ‘virtual int PosixServerSocketImpl::accept(ConnectedSocket*, const SocketOptions&, entity_addr_t*, Worker*)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/PosixStack.cc:281:46: error: request for member ‘get_family’ in ‘out’, which is of pointer type ‘entity_addr_t*’ (maybe you meant to use ‘->’ ?)
   handler.set_priority(sd, opt.priority, out.get_family());
                                              ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/net_handler.cc: In member function ‘void ceph::NetHandler::set_priority(int, int, int)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/net_handler.cc:133:9: error: ‘domain’ was not declared in this scope
     if (domain == AF_INET) {
         ^
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/debug.h:18:0,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/net_handler.cc:26:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/net_handler.cc:137:15: error: ‘msgr’ was not declared in this scope
         ldout(msgr->cct,0) << "couldn't set IP_TOS to " << iptos
see https://jenkins.ceph.com/job/ceph-pull-requests/18449/consoleFull#-10115026382a811ea2-3e7b-466b-84b4-d13df7e35809

@robbat2 robbat2 force-pushed the dreamhost:wip-18928 branch from 04c2805 to 83fd820 Feb 15, 2017

@robbat2

This comment has been minimized.

Copy link
Contributor Author

robbat2 commented Feb 15, 2017

Ah, good catch, I broke it in respin for submission; made consistent to domain now, to match the exist create_socket call.

FYI backporting to Jewel will mean finding the related TOS change it seems, because Jewel's async ms doesn't have even v4 TOS.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Feb 16, 2017

/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/PosixStack.cc: In member function ‘virtual int PosixServerSocketImpl::accept(ConnectedSocket*, const SocketOptions&, entity_addr_t*, Worker*)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/PosixStack.cc:281:46: error: request for member ‘get_family’ in ‘out’, which is of pointer type ‘entity_addr_t*’ (maybe you meant to use ‘->’ ?)
   handler.set_priority(sd, opt.priority, out.get_family());

see https://jenkins.ceph.com/job/ceph-pull-requests/18517/consoleFull#-10115026382a811ea2-3e7b-466b-84b4-d13df7e35809

@robbat2 robbat2 force-pushed the dreamhost:wip-18928 branch from 83fd820 to 8c736b1 Feb 16, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Feb 17, 2017

/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/net_handler.cc: In member function ‘void ceph::NetHandler::set_priority(int, int, int)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/async/net_handler.cc:137:15: error: ‘msgr’ was not declared in this scope
         ldout(msgr->cct,0) << "couldn't set IP_TOS to " << iptos
               ^
msg/async: support IPv6 QoS.
Extend DSCP marking for heartbeat packets to IPv6.

Backport: jewel, luminious
See-Also: http://tracker.ceph.com/issues/18887
Fixes: http://tracker.ceph.com/issues/18928
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>

@robbat2 robbat2 force-pushed the dreamhost:wip-18928 branch from 8c736b1 to eb0f624 Feb 17, 2017

now it builds

@yuriw yuriw merged commit d0c5df3 into ceph:master Feb 21, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@Adirl

This comment has been minimized.

Copy link

Adirl commented Feb 22, 2017

API change breaks rdma messenger
working on a fix

@Adirl

This comment has been minimized.

Copy link

Adirl commented Feb 23, 2017

fixed
msg/async/rdma: Fix broken compilation #13603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.