New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind: cephfs should be built without librados / python-rados #13431

Merged
merged 4 commits into from Feb 15, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Contributor

tchaikov commented Feb 15, 2017

this addresses the build failure at https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos7,DIST=centos7,MACHINE_SIZE=huge/1284//consoleFull , and includes some cleanups along the way.

Scanning dependencies of target cython3_cephfs
/usr/bin/ld: cannot find -lrados
collect2: error: ld returned 1 exit status

Link Error: Ceph FS library not found
make[2]: *** [src/pybind/cephfs3/CMakeFiles/cython3_cephfs] Error 1
make[1]: *** [src/pybind/cephfs3/CMakeFiles/cython3_cephfs.dir/all] Error 2

tchaikov added some commits Feb 15, 2017

pybind: cephfs: do not link against librados
otherwise python-cephfs might fail to build with followin error:

Scanning dependencies of target cython3_cephfs
/usr/bin/ld: cannot find -lrados
collect2: error: ld returned 1 exit status

Link Error: Ceph FS library not found

and apparently, cephfs *can* be built without librados. it's only
dependency is libcephfs.

Signed-off-by: Kefu Chai <kchai@redhat.com>
pybind: fix the cstr(auth_id, ..) call
so cstr() prints the right error message if auth_id does not look right.

Signed-off-by: Kefu Chai <kchai@redhat.com>
pybind: cephfs: add docstring for LibCephFS's __init__()
Signed-off-by: Kefu Chai <kchai@redhat.com>
ceph.spec: python-cephfs no longer depends on python-rados
instead, it "Recommends" python-rados. as "Recommends:" is not supported on
older distros, only enable this on SuSE.

because python-cephfs *can* be used without python-rados. the
constructor of LibCephFS accepts a ceph.conf *or* a rados.Rados
instance.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from onyb and b-ranto Feb 15, 2017

@jan--f

This comment has been minimized.

Member

jan--f commented Feb 15, 2017

LGTM

@tchaikov tchaikov merged commit 833b00c into ceph:master Feb 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-cython-cephfs-without-librados branch Feb 15, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 15, 2017

@jcsp @onyb sorry for jumping the gun, but the build fails more frequently than i expected. so i am merging this. if anything not sounds right in the PR, please shout at me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment