New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: add override in common and misc #13443
Conversation
There are several .swn files in here |
sorry, i will fix it tomorrow morning |
test this please |
e6ac9d6
to
204ee21
Compare
I have updated it. Waiting test result. |
@@ -52,11 +52,11 @@ class RadosDeleteObjectsR : public SysTestRunnable | |||
{ | |||
} | |||
|
|||
~RadosDeleteObjectsR() | |||
~RadosDeleteObjectsR() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuchang0812 trailing space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I will remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -137,11 +137,11 @@ class RadosAddObjectsR : public SysTestRunnable | |||
{ | |||
} | |||
|
|||
~RadosAddObjectsR() | |||
~RadosAddObjectsR() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
there are a lot of tailing spaces in code base.
➜ ceph git:(cleanup-common) ✗ grep -n "\ $" `git diff --name-only HEAD^` | wc -l
grep: src/boost: Is a directory
498
➜ ceph git:(cleanup-common) ✗ grep -nr "\ $" src | wc -l
304750
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuchang0812 just don't want to introduce more in new commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchaikov roger that, I just fixed above 2 lines.
Fixes: http://tracker.ceph.com/issues/18922 Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
204ee21
to
da109b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
Fixes: http://tracker.ceph.com/issues/18922
Signed-off-by: liuchang0812 liuchang0812@gmail.com