New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add override in common and misc #13443

Merged
merged 1 commit into from Feb 16, 2017

Conversation

Projects
None yet
5 participants
@Liuchang0812
Contributor

Liuchang0812 commented Feb 15, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Feb 15, 2017

There are several .swn files in here

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Feb 15, 2017

sorry, i will fix it tomorrow morning

@yuriw

This comment has been minimized.

Contributor

yuriw commented Feb 15, 2017

test this please

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Feb 16, 2017

I have updated it. Waiting test result.

@@ -52,11 +52,11 @@ class RadosDeleteObjectsR : public SysTestRunnable
{
}
~RadosDeleteObjectsR()
~RadosDeleteObjectsR()

This comment has been minimized.

@tchaikov

tchaikov Feb 16, 2017

Contributor

@Liuchang0812 trailing space.

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 16, 2017

Contributor

Good catch! I will remove it

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 16, 2017

Contributor

Done

@@ -137,11 +137,11 @@ class RadosAddObjectsR : public SysTestRunnable
{
}
~RadosAddObjectsR()
~RadosAddObjectsR()

This comment has been minimized.

@tchaikov

tchaikov Feb 16, 2017

Contributor

ditto

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 16, 2017

Contributor

Done.

there are a lot of tailing spaces in code base.

➜  ceph git:(cleanup-common) ✗ grep -n "\ $" `git diff --name-only HEAD^` | wc -l
grep: src/boost: Is a directory
498

➜  ceph git:(cleanup-common) ✗ grep -nr "\ $" src | wc -l                        
304750

This comment has been minimized.

@tchaikov

tchaikov Feb 16, 2017

Contributor

@Liuchang0812 just don't want to introduce more in new commits.

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 16, 2017

Contributor

@tchaikov roger that, I just fixed above 2 lines.

common: add override for common submodule and misc
Fixes: http://tracker.ceph.com/issues/18922

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>

@tchaikov tchaikov merged commit c623b3e into ceph:master Feb 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment