Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add override in common and misc #13443

Merged
merged 1 commit into from Feb 16, 2017

Conversation

liuchang0812
Copy link
Contributor

@liewegas
Copy link
Member

There are several .swn files in here

@liuchang0812
Copy link
Contributor Author

sorry, i will fix it tomorrow morning

@yuriw
Copy link
Contributor

yuriw commented Feb 15, 2017

test this please

@liuchang0812
Copy link
Contributor Author

I have updated it. Waiting test result.

@@ -52,11 +52,11 @@ class RadosDeleteObjectsR : public SysTestRunnable
{
}

~RadosDeleteObjectsR()
~RadosDeleteObjectsR()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuchang0812 trailing space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I will remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -137,11 +137,11 @@ class RadosAddObjectsR : public SysTestRunnable
{
}

~RadosAddObjectsR()
~RadosAddObjectsR()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

there are a lot of tailing spaces in code base.

➜  ceph git:(cleanup-common) ✗ grep -n "\ $" `git diff --name-only HEAD^` | wc -l
grep: src/boost: Is a directory
498

➜  ceph git:(cleanup-common) ✗ grep -nr "\ $" src | wc -l                        
304750

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuchang0812 just don't want to introduce more in new commits.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaikov roger that, I just fixed above 2 lines.

Fixes: http://tracker.ceph.com/issues/18922

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@tchaikov tchaikov merged commit c623b3e into ceph:master Feb 16, 2017
Copy link

@amitkumar50 amitkumar50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants