New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: ignore fs full check for CEPH_MDS_OP_SETFILELOCK #13455

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
3 participants
@ukernel
Member

ukernel commented Feb 16, 2017

Fixes: http://tracker.ceph.com/issues/18953
Signed-off-by: "Yan, Zheng" zyan@redhat.com

mds: ignore fs full check for CEPH_MDS_OP_SETFILELOCK
Fixes: http://tracker.ceph.com/issues/18953
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
@jcsp

jcsp approved these changes Feb 16, 2017

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Feb 17, 2017

We should only do this if we know it won't spawn off writes, and I'm not sure that's the case. Can't the process of us trying to take locks force lock recalls and things that require journaling?

@ukernel

This comment has been minimized.

Member

ukernel commented Feb 20, 2017

filelock operations only change in-memory state. mds never journal them

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Feb 20, 2017

Yes, but acquire_locks() can twiddle lock states in ways that require journal commits. Right?

@jcsp

This comment has been minimized.

Contributor

jcsp commented Feb 22, 2017

This would not be the only full-permitted op that can generate journal writes -- IMO allowing this one is necessary because you could very well see application logic that wanted to acquire a lock before doing some deletions of application data.

@jcsp jcsp merged commit fa55ed5 into ceph:master Feb 22, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ukernel ukernel deleted the ukernel:wip-18953 branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment