New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for is_hacky_ecoverwrites in cephfs pool checks #13466

Merged
merged 1 commit into from Apr 15, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Feb 16, 2017

No description provided.

@jcsp jcsp added cephfs core labels Feb 16, 2017

@jcsp

This comment has been minimized.

Contributor

jcsp commented Feb 16, 2017

@athanatos @liewegas is this a useful thing to have in master for folks working on ec overwrite stuff? Obviously it's all still disabled by default on clusters until someone sets their enable_experimental_unrecoverable_data_corrupting_features etc

@jdurgin

This comment has been minimized.

Member

jdurgin commented Feb 16, 2017

This is useful - though I'll be removing the 'hacky' part of the flag soon. It would help to get more testing on cephfs (another facet in one of the cephfs suites?) as well. The branch I'm working on is https://github.com/ceph/ceph-ci/commits/wip-ec-overwrites-cleanup

@jcsp

This comment has been minimized.

Contributor

jcsp commented Feb 16, 2017

@jdurgin cool, with the testing I think the way we'll go is to update filesystem.py to take a flag for using EC when creating its pools, then add a config option to the ceph.py task. For actually adding the permutation to the suites, we currently run the fs suite exhaustively, we're sort of about to hit the limit of that, but I think we might need something smart to do subsets of things like EC vs. replicated, while remaining exhaustive on the cephfs permutations (I sent a mail to ceph-devel)

@jcsp

This comment has been minimized.

Contributor

jcsp commented Feb 28, 2017

Turns out I accidentally included the functional part of this in https://github.com/ceph/ceph/pull/13581/files, so this PR is just the test now.

test: test cephfs pool ops with ec overwrites
Signed-off-by: John Spray <john.spray@redhat.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented Apr 12, 2017

retest this please

@jcsp jcsp changed the title from Respect is_hacky_ecoverwrites in cephfs pool checks to Add test for is_hacky_ecoverwrites in cephfs pool checks Apr 13, 2017

@jcsp jcsp requested review from tchaikov and jdurgin Apr 13, 2017

@jcsp

This comment has been minimized.

Contributor

jcsp commented Apr 14, 2017

@tchaikov @jdurgin this looks to be passing based on the jenkins check

# We should be permitted to use an EC pool with overwrites enabled
# as the data pool...
ceph osd pool set mds-ec-pool debug_white_box_testing_ec_overwrites true --yes-i-really-mean-it

This comment has been minimized.

@tchaikov

tchaikov Apr 14, 2017

Contributor

i think, in long term, maybe we should rely on teuthology to perform the integration tests. and we have qa/suites/rbd/cli/pool/ec-data-pool.yaml to enable this feature. but i have no strong opinion on this though.

if @jdurgin is happy, i am fine.

@jcsp jcsp merged commit 0cb0c49 into ceph:master Apr 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-cephfs-ecoverwrites branch Apr 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment