New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: don't log the env_map twice #13481

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
2 participants
@theanalyst
Member

theanalyst commented Feb 17, 2017

We already print the env_map during the RGWEnv::set operation,
making this redundant

Signed-off-by: Abhishek Lekshmanan abhishek@suse.com

@theanalyst

This comment has been minimized.

Member

theanalyst commented Feb 17, 2017

Alternatively we could keep this and drop the dout in RGWEnv::set

@cbodley

This comment has been minimized.

Contributor

cbodley commented Feb 17, 2017

@theanalyst if i had to choose, i'd keep the logging in BasicClient::init() just so they're ordered alphabetically. but i'm fine either way 👍

@theanalyst

This comment has been minimized.

Member

theanalyst commented Feb 17, 2017

@cbodley yeah makes sense in a way, also a little bit cleaner looking, (since we wouldn't have the various RGWEnv::set() prefixes before the values

rgw: don't log the client env_map twice
We currently log the client HTTP env vars twice, once while the env map
is being set and second when the client_io is initiated, this commit
avoids the redundant logging while setting the map

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst

This comment has been minimized.

Member

theanalyst commented Feb 17, 2017

@cbodley updated

@theanalyst theanalyst changed the title from rgw: client_io: avoid printing the env_map twice to rgw: don't log the env_map twice Mar 7, 2017

@cbodley cbodley merged commit 75be7ea into ceph:master Mar 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment