New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: build ceph-resource-agents by default #13515

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Feb 18, 2017

To align with debian build

Fixes: http://tracker.ceph.com/issues/17613
Signed-off-by: Nathan Cutler ncutler@suse.com

rpm: build ceph-resource-agents by default
To align with debian build

Fixes: http://tracker.ceph.com/issues/17613
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Feb 18, 2017

Jenkins re-test this please (unrelated rbd-mirror test failure)

@@ -14,7 +14,7 @@
#
# Please submit bugfixes or comments via http://tracker.ceph.com/
#
%bcond_with ocf
%bcond_without ocf

This comment has been minimized.

@tchaikov

tchaikov Feb 19, 2017

Contributor

maybe the package name of "resource-agents" is too general, and there is an existing package named exactly the same, which is "Required" by our "resource-agents" as put by the "ceph.spec.in". see https://github.com/ClusterLabs/resource-agents/blob/master/resource-agents.spec.in and http://centos-packages.com/7/package/resource-agents/ . shall we rename it to ceph-resource-agent?

seems opensuse has renamed it already? https://rpmfind.net/linux/RPM/opensuse/updates/leap/42.2/oss/x86_64/ceph-resource-agents-10.2.4+git.1481215985.12b091b-4.1.x86_64.html @smithfarm is that you ? =)

This comment has been minimized.

@smithfarm

smithfarm Feb 19, 2017

Contributor

@tchaikov Actually, it already is called ceph-resource-agents due to the way RPM parses spec files. To make it be resource-agents there would need to be a -n in this line:

%package resource-agents

But, yes, in openSUSE the ocf build is enabled.

This comment has been minimized.

@tchaikov

tchaikov Feb 19, 2017

Contributor

very cool! thank you @smithfarm ! now i understand why we also package selinux ! =D

This comment has been minimized.

This comment has been minimized.

@smithfarm

smithfarm Feb 19, 2017

Contributor

@tchaikov Yes, and for example why the ceph-osd package is called that and not merely osd :-P

@ktdreyer

thanks, it's a good idea to keep the deb and rpm packaging in sync.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Feb 21, 2017

Pushed wip-17613 to Shaman.

@smithfarm smithfarm merged commit 374423e into ceph:master Feb 21, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@smithfarm smithfarm deleted the smithfarm:wip-17613 branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment