Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: drop boost build dependencies #13519

Merged
merged 1 commit into from Feb 19, 2017

Conversation

Projects
None yet
2 participants
@smithfarm
Copy link
Contributor

smithfarm commented Feb 19, 2017

The boost-python build dependency was added by 8897757 the description of which indicates that it was needed by ceph-mgr.

@smithfarm smithfarm requested review from tchaikov and jcsp Feb 19, 2017

rpm: drop boost build dependencies
The boost library is now a submodule.

Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm force-pushed the smithfarm:wip-drop-boost-devel branch from 1f63ff5 to fcc5529 Feb 19, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Feb 19, 2017

Pushed wip-drop-boost-devel to Shaman.

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Feb 19, 2017

Passes Shaman, but fails run-make-check.sh . . . @tchaikov Any idea why? (I'm assuming that make check is somehow dependent on boost-devel but that's a pretty vague assumption) I grepped some but cannot see what would be dlopening /lib/compressor/libceph_invalid.so

[----------] 1 test from CompressionPlugin
[ RUN      ] CompressionPlugin.all
2017-02-19 09:05:48.818100 7f324b58aec0 -1 load failed dlopen(): "/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/compressor/libceph_invalid.so: cannot open shared object file: No such file or directory" or "/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libceph_invalid.so: cannot open shared object file: No such file or directory"
*** Caught signal (Segmentation fault) **
 in thread 7f324b58aec0 thread_name:unittest_compre
 ceph version 12.0.0-535-g251e2ea (251e2ea676294ecbc60c36b41e9b0f53ad524274)
 1: (()+0x67d47) [0x7f324b38ad47]
 2: (()+0x10330) [0x7f324aef0330]
 3: (std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()+0x36) [0x7f324b358986]
 4: (CompressionPlugin_all_Test::TestBody()+0x9ed) [0x7f324b355bad]
 5: (void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x33) [0x7f324b382983]
 6: (testing::Test::Run()+0xb7) [0x7f324b375d57]
 7: (testing::TestInfo::Run()+0x9e) [0x7f324b375dfe]
 8: (testing::TestCase::Run()+0xa5) [0x7f324b375f05]
 9: (testing::internal::UnitTestImpl::RunAllTests()+0x248) [0x7f324b3761b8]
 10: (testing::UnitTest::Run()+0x54) [0x7f324b376474]
 11: (main()+0x11c) [0x7f324b350f9c]
 12: (__libc_start_main()+0xf5) [0x7f324193ef45]
 13: (()+0x2e486) [0x7f324b351486]
2017-02-19 09:05:48.818902 7f324b58aec0 -1 *** Caught signal (Segmentation fault) **
 in thread 7f324b58aec0 thread_name:unittest_compre
@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Feb 19, 2017

@smithfarm the failure to dlopen() libceph_invalid.so is expected., see https://github.com/ceph/ceph/blob/master/src/test/compressor/test_compression.cc#L374, the culprit causing segfaulted is the refcounter of CompressorRef compressor. compressor is a shared_ptr whose refcount is tracked by std::_Sp_counted_base<>, seems that shared_ptr is corrupted or something, so when we were decreasing the refcount it crashed. i am looking at this.

@smithfarm

This comment has been minimized.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Feb 19, 2017

[ RUN      ] CompressionPlugin.all
2017-02-19 19:41:34.064306 7f95527b5440 -1 load failed dlopen(): "/var/ceph/ceph/build/lib/compressor/libceph_invalid.so: cannot open shared object file: No such file or directory"
 or "/var/ceph/ceph/build/lib/libceph_invalid.so: cannot open shared object file: No such file or directory"
[       OK ] CompressionPlugin.all (0 ms)

i checked out your branch, and this test passed.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Feb 19, 2017

[ RUN      ] CompressionPlugin.all
2017-02-19 09:05:48.818100 7f324b58aec0 -1 load failed dlopen(): "/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/compressor/libceph_invalid.so: cannot open shared object file: No such file or directory" or "/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libceph_invalid.so: cannot open shared object file: No such file or directory"
*** Caught signal (Segmentation fault) **
 in thread 7f324b58aec0 thread_name:unittest_compre
 ceph version 12.0.0-535-g251e2ea (251e2ea676294ecbc60c36b41e9b0f53ad524274)
 1: (()+0x67d47) [0x7f324b38ad47]
 2: (()+0x10330) [0x7f324aef0330]
 3: (std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()+0x36) [0x7f324b358986]
 4: (CompressionPlugin_all_Test::TestBody()+0x9ed) [0x7f324b355bad]
 5: (void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x33) [0x7f324b382983]
 6: (testing::Test::Run()+0xb7) [0x7f324b375d57]
 7: (testing::TestInfo::Run()+0x9e) [0x7f324b375dfe]
 8: (testing::TestCase::Run()+0xa5) [0x7f324b375f05]
 9: (testing::internal::UnitTestImpl::RunAllTests()+0x248) [0x7f324b3761b8]
 10: (testing::UnitTest::Run()+0x54) [0x7f324b376474]
 11: (main()+0x11c) [0x7f324b350f9c]
 12: (__libc_start_main()+0xf5) [0x7f324193ef45]
 13: (()+0x2e486) [0x7f324b351486]
2017-02-19 09:05:48.818902 7f324b58aec0 -1 *** Caught signal (Segmentation fault) **
 in thread 7f324b58aec0 thread_name:unittest_compre

see https://jenkins.ceph.com/job/ceph-pull-requests/18762/

retest this please

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Feb 19, 2017

@tchaikov Thanks - I couldn't find anything boost-related about that crash either.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Feb 19, 2017

@tchaikov tchaikov removed the needs-qa label Feb 19, 2017

@smithfarm smithfarm changed the title [DNM] rpm: drop boost build dependencies rpm: drop boost build dependencies Feb 19, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Feb 19, 2017

#13524 makes the same change for Debian, and has been merged.

@tchaikov tchaikov merged commit e09de2c into ceph:master Feb 19, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.