Join GitHub today
client/Client.cc: after reset session from MDS - reconnect #13522
Client.cc marks session as stale instead of reconecting after received
Signed-off-by: Henrik Korkuc email@example.com
That was the only place that STATE_STALE was set, so the flag is now unused. The kick_stale_sessions command also becomes meaningless once STATE_STALE is no longer used. If we go down this path then the patch needs to remove the now-dead bits too.
The stale handling stuff was added in this commit from @ukernel :
I'm guessing the whole idea of that change was to make this an explicit human-driven process, rather than automatically reconnecting, presumably because reconnecting in this situation is not necessarily safe/healthy, because things might have changed while the client was away.
In practice I think most users are not going to understand/use the kick_stale_sessions command though.
More discussion is probably needed.