Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: Add missing tp files in deb packaging #13526

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
2 participants
@ganeshmaharaj
Copy link
Contributor

ganeshmaharaj commented Feb 20, 2017

DEB packaging builds happen with LTTNG enabled but are missing a few
files.

  • libosd_tp.so*, libos_tp.so* are needed to trace OSD
  • librados_tp.so, librbd_tp.so are needed along with the other files
    for trace visibility within lttng tool.

Signed-off-by: Ganesh Mahalingam ganesh.mahalingam@intel.com

@ganeshmaharaj ganeshmaharaj changed the title Add missing tp files in deb packaging tracing: Add missing tp files in deb packaging Feb 20, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Feb 20, 2017

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it would be "debian: ".

@tchaikov
Copy link
Contributor

tchaikov left a comment

modulo the nit about commit message title, lgtm

@tchaikov tchaikov changed the title tracing: Add missing tp files in deb packaging debian: Add missing tp files in deb packaging Feb 20, 2017

@ganeshmaharaj

This comment has been minimized.

Copy link
Contributor Author

ganeshmaharaj commented Feb 20, 2017

@tchaikov thank you very much for changing the topic this time. Will follow the suggestions going forward.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Feb 20, 2017

@ganeshmaharaj i mean, maybe you can "git amend" the commit, and "git push -f" to your remote repo? the title of the comment on github is different from the title of your commit.

debian: Add missing tp files in deb packaging
DEB packaging builds happen with LTTNG enabled but are missing a few
files.
*  libosd_tp.so*, libos_tp.so* are needed to trace OSD
*  librados_tp.so, librbd_tp.so are needed along with the other files
for trace visibility within lttng tool.

Signed-off-by: Ganesh Mahalingam <ganesh.mahalingam@intel.com>
@ganeshmaharaj

This comment has been minimized.

Copy link
Contributor Author

ganeshmaharaj commented Feb 20, 2017

@tchaikov aah, didn't catch it the first time. Apologies. Fixed & pushed my commit.

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit a8122af into ceph:master Feb 27, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov self-assigned this Feb 27, 2017

@ganeshmaharaj ganeshmaharaj deleted the ganeshmaharaj:tp_library_fixes branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.