New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: add override in header files #13536

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@Liuchang0812
Contributor

Liuchang0812 commented Feb 20, 2017

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Feb 20, 2017

Contributor

@dillaman @liewegas Please take a look. as we talked in #13437

Contributor

Liuchang0812 commented Feb 20, 2017

@dillaman @liewegas Please take a look. as we talked in #13437

Show outdated Hide outdated src/librbd/AioImageRequest.h Outdated
Show outdated Hide outdated src/librbd/AioImageRequest.h Outdated
Show outdated Hide outdated src/librbd/AioImageRequest.h Outdated
Show outdated Hide outdated src/librbd/AioImageRequest.h Outdated
Show outdated Hide outdated src/librbd/AioImageRequest.h Outdated
Show outdated Hide outdated src/librbd/Watcher.h Outdated
Show outdated Hide outdated src/librbd/cache/PassthroughImageCache.h Outdated
Show outdated Hide outdated src/librbd/cache/PassthroughImageCache.h Outdated
Show outdated Hide outdated src/librbd/cache/PassthroughImageCache.h Outdated
Show outdated Hide outdated src/tools/rbd_mirror/MirrorStatusWatcher.h Outdated
@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Feb 20, 2017

Contributor

@dillaman what's wrong with indentation

Contributor

Liuchang0812 commented Feb 20, 2017

@dillaman what's wrong with indentation

@dillaman

This comment has been minimized.

Show comment
Hide comment
@dillaman

dillaman Feb 20, 2017

Contributor

@Liuchang0812 The params on the next line should align with the params on the previous line -- they don't now after the "virtual " keyword was removed.

Contributor

dillaman commented Feb 20, 2017

@Liuchang0812 The params on the next line should align with the params on the previous line -- they don't now after the "virtual " keyword was removed.

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Feb 20, 2017

Contributor

@dillaman thanks I don't know how to fix this by clang-tidy automatically , I will correct it by hands tomorrow

Contributor

Liuchang0812 commented Feb 20, 2017

@dillaman thanks I don't know how to fix this by clang-tidy automatically , I will correct it by hands tomorrow

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Feb 21, 2017

Contributor

@dillaman It seems that I have fixed all indentation problems. Could you take a look again. Very thanks.

Contributor

Liuchang0812 commented Feb 21, 2017

@dillaman It seems that I have fixed all indentation problems. Could you take a look again. Very thanks.

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Feb 21, 2017

Contributor

There are some CE because I rebased branch. I'm fixing it.

Contributor

Liuchang0812 commented Feb 21, 2017

There are some CE because I rebased branch. I'm fixing it.

librbd: add override in header files
Fixes: http://tracker.ceph.com/issues/19012

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@dillaman

lgtm -- thanks!

@dillaman dillaman merged commit e2f14be into ceph:master Feb 21, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment