New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: remove copy-get-classic #13547

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Feb 20, 2017

This hasn't been used since well before hammer.

Signed-off-by: Sage Weil sage@redhat.com

@tchaikov

shall we note this in the "Compatibility changes" section in release-notes.rst?

classic = true;
}
fill_in_copy_get_noent(op, oid, m->ops[0], classic);
(m->ops[0].op.op == CEPH_OSD_OP_COPY_GET)) {

This comment has been minimized.

@tchaikov

tchaikov Feb 21, 2017

Contributor

could remove the parentheses around m->ops[0].op.op == CEPH_OSD_OP_COPY_GET.

@liewegas liewegas added the needs-qa label Feb 23, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Feb 23, 2017

I can't really imagine why someone would be using the 'copy-get-classic' rados op explicitly (vs 'copy-get'), but we can add it anyway!

osd: remove copy-get-classic
This hasn't been used since well before hammer.

Signed-off-by: Sage Weil <sage@redhat.com>

@yuriw yuriw merged commit f15d025 into ceph:master Feb 27, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment