New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: fix bug in _open_super_meta() #13559

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
3 participants
@voidbag
Contributor

voidbag commented Feb 21, 2017

os/bluestore: fix bug in _open_super_meta
If rocksdb isn't used, kvbackend can't have the key 'bluefs_extents'.

Signed-off-by: Taeksang Kim voidbag@gmail.com

@voidbag

This comment has been minimized.

Show comment
Hide comment
@voidbag

voidbag Mar 7, 2017

Contributor

@tchaikov
I have updated the pr, based on your comment.

Thanks.

Contributor

voidbag commented Mar 7, 2017

@tchaikov
I have updated the pr, based on your comment.

Thanks.

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Mar 7, 2017

Contributor

@voidbag could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it would be "os/bluestore: " .

and also "_open_super_meta() in BlueStore.cc " is too vague, could you be more specific?

Contributor

tchaikov commented Mar 7, 2017

@voidbag could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it would be "os/bluestore: " .

and also "_open_super_meta() in BlueStore.cc " is too vague, could you be more specific?

os/bluestore: get 'bluefs_extents' only /w bluefs
kv_backend other than rocksdb can't have 'bluefs_extents'

Signed-off-by: Taeksang Kim <voidbag@gmail.com>
@voidbag

This comment has been minimized.

Show comment
Hide comment
@voidbag

voidbag Mar 7, 2017

Contributor

@tchaikov
I updated commit message specifically, with prefix 'os/bluestore: '

Thanks

Contributor

voidbag commented Mar 7, 2017

@tchaikov
I updated commit message specifically, with prefix 'os/bluestore: '

Thanks

@tchaikov tchaikov requested a review from liewegas Mar 7, 2017

@tchaikov tchaikov added the needs-qa label Mar 7, 2017

@tchaikov tchaikov merged commit fa54a27 into ceph:master Mar 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment