New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplicatedBackend: don't queue Context outside of ObjectStore with obc #13569

Merged
merged 1 commit into from Feb 23, 2017

Conversation

Projects
None yet
3 participants
@athanatos
Contributor

athanatos commented Feb 21, 2017

We only flush the ObjectStore callbacks, not everything else. Thus,
there isn't a guarrantee that the obc held by pull_complete_info will
be cleaned up before the Flush callback is triggered. Instead, just
defer clearing the pull state until the callback (it'll be cleaned up
during the interval change) and remove the ObjectContext from
pull_complete_info.

Introduced: 68defc2
Fixes: http://tracker.ceph.com/issues/18927
Signed-off-by: Samuel Just sjust@redhat.com

ReplicatedBackend: don't queue Context outside of ObjectStore with obc
We only flush the ObjectStore callbacks, not everything else.  Thus,
there isn't a guarrantee that the obc held by pull_complete_info will
be cleaned up before the Flush callback is triggered.  Instead, just
defer clearing the pull state until the callback (it'll be cleaned up
during the interval change) and remove the ObjectContext from
pull_complete_info.

Introduced: 68defc2
Fixes: http://tracker.ceph.com/issues/18927
Signed-off-by: Samuel Just <sjust@redhat.com>

@athanatos athanatos requested review from liewegas and jdurgin Feb 21, 2017

@athanatos

This comment has been minimized.

Contributor

athanatos commented Feb 21, 2017

@liewegas liewegas merged commit 292306c into ceph:master Feb 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment