Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: correct the func name in execute_ctx() log messages #13582

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
4 participants
@guzhongyan
Copy link
Contributor

guzhongyan commented Feb 22, 2017

Wrong function name in execute_ctx log

Signed-off-by: Gu Zhongyan guzhongyan@360.cn

@@ -2970,13 +2970,13 @@ void PrimaryLogPG::execute_ctx(OpContext *ctx)
ctx->at_version = get_next_version();
ctx->mtime = m->get_mtime();

dout(10) << "do_op " << soid << " " << ctx->ops
dout(10) << __func__ << soid << " " << ctx->ops

This comment has been minimized.

Copy link
@tchaikov

tchaikov Feb 23, 2017

Contributor

could have a space after __func__.

This comment has been minimized.

Copy link
@guzhongyan

guzhongyan Feb 24, 2017

Author Contributor

Done.

hjwsm1989 pushed a commit to hjwsm1989/ceph that referenced this pull request Feb 23, 2017

rgw: Do not send a Content-Length header on status 204
RFC7230 says:
  A server MUST NOT send a Content-Length header field in any response with a
  status code of 1xx (Informational) or 204 (No Content).

Fixes: ceph#13582
Signed-off-by: Wido den Hollander <wido@42on.com>
(cherry picked from commit 4e5921d)
osd: cleanup execute_ctx log
Wrong function name in execute_ctx log

Signed-off-by: Gu Zhongyan <guzhongyan@360.cn>

@guzhongyan guzhongyan force-pushed the guzhongyan:cleanup_execute_ctx branch from 808f1a6 to 4894e96 Feb 24, 2017

@tchaikov tchaikov changed the title osd: cleanup execute_ctx log osd: correct the func name in execute_ctx() log messages Feb 24, 2017

@guzhongyan

This comment has been minimized.

Copy link
Contributor Author

guzhongyan commented Mar 1, 2017

Anything else I need to do? I see some build error. Can it be merged?

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Mar 1, 2017

retest this please (jenkins log expired)

@tchaikov tchaikov added the needs-qa label Mar 1, 2017

@guzhongyan

This comment has been minimized.

Copy link
Contributor Author

guzhongyan commented Mar 1, 2017

So how to trigger the retesting?

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Mar 1, 2017

test this please

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Mar 1, 2017

@guzhongyan yuri just said it.

@yuriw yuriw merged commit 2a5b235 into ceph:master Mar 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@guzhongyan guzhongyan deleted the guzhongyan:cleanup_execute_ctx branch Mar 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.