New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: add override in header files mostly #13586

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Projects
None yet
3 participants
@Liuchang0812
Contributor

Liuchang0812 commented Feb 22, 2017

Signed-off-by: liuchang0812 liuchang0812@gmail.com

virtual void init(RGWRados *store, struct req_state *s,
RGWHandler *dialect_handler) {
void init(RGWRados *store, struct req_state *s,
RGWHandler *dialect_handler) override {

This comment has been minimized.

@cbodley

cbodley Feb 22, 2017

Contributor

indentation

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 23, 2017

Contributor

done

struct req_state *s,
rgw::io::BasicClient *cio);
virtual int authorize() {
rgw::io::BasicClient *cio) override;

This comment has been minimized.

@cbodley

cbodley Feb 22, 2017

Contributor

indentation

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 23, 2017

Contributor

done

struct req_state *s,
rgw::io::BasicClient *cio);
virtual int authorize() {
rgw::io::BasicClient *cio) override;

This comment has been minimized.

@cbodley

cbodley Feb 22, 2017

Contributor

indentation

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 23, 2017

Contributor

done

virtual RGWRESTMgr *get_resource_mgr(struct req_state* const s,
RGWRESTMgr *get_resource_mgr(struct req_state* const s,

This comment has been minimized.

@cbodley

cbodley Feb 22, 2017

Contributor

indentation

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 23, 2017

Contributor

done

const std::string& uri,
std::string* const out_uri) override {
return this;
}
virtual RGWHandler_REST* get_handler(struct req_state*,
RGWHandler_REST* get_handler(struct req_state*,

This comment has been minimized.

@cbodley

cbodley Feb 22, 2017

Contributor

indentation

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 23, 2017

Contributor

done

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Feb 23, 2017

@cbodley It seems that all issues have been cleaned.

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 8, 2017

@cbodley hi, could we merge it now?

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 8, 2017

@Liuchang0812 just trying to be careful about the timing for merge, because we'll need to rebase a lot of other PRs afterwards. what do you think, @yehudasa? is there stuff you want to get merged before this?

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 8, 2017

@cbodley okay

@yehudasa

This comment has been minimized.

Member

yehudasa commented Mar 8, 2017

@cbodley @Liuchang0812 yeah, let's get wip-bucket-cleanup in first.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 13, 2017

@Liuchang0812 can you please rebase?

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 14, 2017

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 14, 2017

change log:

  1. rebased to master
  2. squashed all commits
  3. repushed
rgw/cleanup: add override in headers
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>

@cbodley cbodley merged commit 8e77ea4 into ceph:master Mar 14, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment