New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_file: avoid stranding invalid-name bucket handles in fhcache #13590

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
3 participants
@mattbenjamin
Contributor

mattbenjamin commented Feb 22, 2017

To avoid a string copy in the common mkdir path, handles for
proposed buckets currently are staged in the handle table, before
being rejected. They need to be destaged, not just marked deleted
(because deleted objects are now assumed not to be linked, as of
beaeff0).

This triggered an unhandled Boost assert when deleting staged
handles, as current safe_link mode requires first removing from
the FHCache.

Fixes: http://tracker.ceph.com/issues/19036

Signed-off-by: Matt Benjamin mbenjamin@redhat.com

rgw_file: avoid stranding invalid-name bucket handles in fhcache
To avoid a string copy in the common mkdir path, handles for
proposed buckets currently are staged in the handle table, before
being rejected.  They need to be destaged, not just marked deleted
(because deleted objects are now assumed not to be linked, as of
beaeff0).

This triggered an unhandled Boost assert when deleting staged
handles, as current safe_link mode requires first removing from
the FHCache.

Fixes: http://tracker.ceph.com/issues/19036

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

@mattbenjamin mattbenjamin self-assigned this Feb 22, 2017

@mattbenjamin mattbenjamin requested a review from cbodley Feb 22, 2017

@mattbenjamin mattbenjamin merged commit 98b28d6 into ceph:master Feb 22, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Mar 27, 2017

Contributor

@ktdreyer @cbodley This PR apparently fixes two tracker issues:

Both of which got marked "Pending Backport", hence the duplicate backports. Cleaning up now.

Contributor

smithfarm commented Mar 27, 2017

@ktdreyer @cbodley This PR apparently fixes two tracker issues:

Both of which got marked "Pending Backport", hence the duplicate backports. Cleaning up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment