New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "ceph-disk: change get_dmcrypt_key test to support different cluster name"" #13600

Merged
merged 1 commit into from Feb 28, 2017

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Feb 23, 2017

This reverts commit d3409d4 which
reverted 1c74747. Although in the same
pull request, 1c74747 was a fix for
d98d4db. The two should have been
squashed but they were not.

When reverting the pull request I reverted all the commits in the pull
request but I did it in the wrong order and the fix became the
problem. Luckily the outcome is a noop instead of a bug, reason why
it was undetected by the tests.

Signed-off-by: Loic Dachary ldachary@redhat.com

Revert "Revert "ceph-disk: change get_dmcrypt_key test to support dif…
…ferent cluster name""

This reverts commit d3409d4 which
reverted 1c74747. Although in the same
pull request, 1c74747 was a fix for
d98d4db. The two should have been
squashed but they were not.

When reverting the pull request I reverted all the commits in the pull
request but I did it in the wrong order and the fix became the
problem. Luckily the outcome is a noop instead of a bug, reason why
it was undetected by the tests.

Signed-off-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost added cleanup core labels Feb 23, 2017

@ghost ghost requested a review from tchaikov Feb 23, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 23, 2017

will take a look tmr.

@ghost

This comment has been minimized.

ghost commented Feb 23, 2017

@tchaikov thanks, no rush though, it can wait

@tchaikov tchaikov merged commit 50a0fe4 into ceph:master Feb 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment