New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: add support for multipart upload expiration. #13622

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
5 participants
@zhangsw
Contributor

zhangsw commented Feb 24, 2017

Add multipart upload expiration in S3 lifecycle. With this feature, a multipart upload will be aborted if it's not finished after a certain time.
Move some functions about multipart defined in rgw_op.cc to rgw_multi.h and rgw_multi.cc so that we can reuse the code in lifecycle process.

Fixes: http://tracker.ceph.com/issues/19088

Signed-off-by: Zhang Shaowen zhangshaowen@cmss.chinamobile.com

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Feb 24, 2017

@yehudasa @cbodley @dang please help review this, thanks~

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Mar 30, 2017

@dang ping...

@dang

dang approved these changes Mar 31, 2017

Looks good to me. Sorry for the delay; I somehow missed it the first time around.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 31, 2017

@zhangsw what will it take to get test coverage in s3tests?

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Apr 1, 2017

@cbodley The boto doesn't support this feature while boto3 does. I've tried to use boto3 in s3test but it seems that it's not easy to do this. Any advice about this?

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 3, 2017

@zhangsw what exactly is missing from boto here?

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Apr 5, 2017

@cbodley boto doesn't support the parameters for multipart upload expiration in its method to config bucket lifecycle.

rgw: add support for multipart upload expiration.
Fixes: http://tracker.ceph.com/issues/19088

Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com>
@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Apr 5, 2017

rebase this pr

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 6, 2017

thanks @zhangsw, i created a task at http://tracker.ceph.com/issues/19519 so we don't forget about it

@cbodley cbodley merged commit 4e793bf into ceph:master Apr 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@theanalyst

This comment has been minimized.

Member

theanalyst commented Apr 7, 2017

For the object tagging functionality as well there isn't support in boto2, I've also written local tests in boto3 but is not trivial to directly port to boto2 (we might have to write our own using requests + using boto just for authentication maybe?)

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 7, 2017

@theanalyst thanks for pointing that out. i asked @yehudasa about this yesterday, and he mentioned that there are some existing s3tests that use _make_request() to generate requests that aren't otherwise part of the boto api. it looks like that should work for both of these cases (tags and multipart expiration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment