New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/workunit: use the suite repo for cloning workunit #13625

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Feb 24, 2017

as "workunits" reside in ceph/qa/workunits, it's more intuitive to
respect suite-repo option when cloning workunits.

Signed-off-by: Kefu Chai kchai@redhat.com

qa/tasks/workunit: use the suite repo for cloning workunit
as "workunits" reside in ceph/qa/workunits, it's more intuitive to
respect suite-repo option when cloning workunits.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the tests label Feb 24, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 24, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 24, 2017

@idryomov idryomov self-assigned this Feb 24, 2017

@idryomov

This comment has been minimized.

Contributor

idryomov commented Feb 24, 2017

Is your teuthology checkout up to date? It should have picked up the suite_sha1 for workunits.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 24, 2017

@idryomov no, it wasn't. i am rescheduling another run with the latest teuthology. thanks for looking at it!

http://pulpito.ceph.com/kchai-2017-02-24_10:52:51-rados-master---basic-mira/

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 24, 2017

works as expected

   workunit:
      sha1: 4cf28de4c9a60a4618d101f555f5a2e59b7ab109
...
2017-02-24T11:00:05.807 INFO:teuthology.orchestra.run.mira066:Running: 'rm -rf /home/ubuntu/cephtest/clone.client.0 && git clone https://github.com/tchaikov/ceph.git /home/ubuntu/cephtest/clone.client.0 && cd -- /home/ubuntu/cephtest/clone.client.0 && git checkout 4cf28de4c9a60a4618d101f555f5a2e59b7ab109'
2017-02-24T11:00:05.997 INFO:tasks.workunit.client.0.mira066.stdout:Cloning into '/home/ubuntu/cephtest/clone.client.0'...
2017-02-24T11:00:36.488 INFO:tasks.workunit.client.0.mira066.stderr:Note: checking out '4cf28de4c9a60a4618d101f555f5a2e59b7ab109'.

see http://pulpito.ceph.com/kchai-2017-02-24_10:52:51-rados-master---basic-mira/855463/

@idryomov

I agree with @dillaman, we shouldn't need the ceph-ci -> ceph thing anymore.

@dillaman

lgtm

@tchaikov tchaikov merged commit 8e36dad into ceph:master Feb 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-suite-repo-for-workunit branch Feb 24, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented Feb 24, 2017

@tchaikov Might be a good idea to send out an email to ceph-devel and sepia mailing lists saying you need to update your local teuthology tooling in order to run workunit tests now.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 24, 2017

@dillaman sure, will send a mail shortly.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 24, 2017

and thanks for the reminder!

@idryomov

This comment has been minimized.

Contributor

idryomov commented Feb 24, 2017

I don't think you need to update. It's the teuthology that's running the jobs that matters, and it's updated. You won't get the new "pick up suite_sha1 for workunits" functionality unless you update, that should be it.

@dillaman

This comment has been minimized.

Contributor

dillaman commented Feb 24, 2017

@idryomov ... but it no longer scans both ceph and ceph-ci searching for the SHA1 ref. If I have a branch w/ this PR, workunit tasks will now only search in the "suite repo". If that is always set to the ceph repo, I guess it will still work.

@idryomov

This comment has been minimized.

Contributor

idryomov commented Feb 24, 2017

Well that's a task change, not a teuthology change. My point was that you don't need to update your local teuthology checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment