Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/librbd/CMakeLists.txt: ceph_test_librbd_fsx requires linux includes/libs #13630

Merged
merged 1 commit into from Feb 28, 2017

Conversation

Projects
None yet
3 participants
@wjwithagen
Copy link
Contributor

wjwithagen commented Feb 24, 2017

  • So exclude the test

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@@ -123,6 +123,7 @@ target_link_libraries(ceph_test_librbd_api
set_target_properties(ceph_test_librbd_api PROPERTIES COMPILE_FLAGS
${UNITTEST_CXX_FLAGS})

ifdef(LINUX)

This comment has been minimized.

Copy link
@tchaikov

tchaikov Feb 24, 2017

Contributor

probably what you meant is

if(DEFINED LINUX)

but i'd suggest use

if(LINUX)

for consistency.

but can we just disable the krbd support in fsx.cc? is there any other linux specific bits in it?

This comment has been minimized.

Copy link
@wjwithagen

wjwithagen Feb 24, 2017

Author Contributor

@tchaikov
Arggh, sometimes my head overflows with all the syntax versions.
And I did not copy my wip-version because master changed too much.
And redoing it seemed easier.
have fixed/rebased.

@tchaikov tchaikov added the rbd label Feb 24, 2017

@tchaikov tchaikov requested a review from dillaman Feb 24, 2017

test/librbd/CMakeLists.txt: ceph_test_librbd_fsx requires linux inclu…
…des/libs

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

@wjwithagen wjwithagen force-pushed the wjwithagen:wip-wjw-fsx-linux branch from 45319b2 to 1827c69 Feb 24, 2017

@tchaikov tchaikov merged commit 4f9580d into ceph:master Feb 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-fsx-linux branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.