New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: set dumpable flag after setuid post ff0e521 #13657

Merged
merged 1 commit into from Mar 1, 2017

Conversation

Projects
None yet
2 participants
@badone
Contributor

badone commented Feb 27, 2017

ff0e521 resolved the issue for the other daemons but not for rgw since
it calls setuid (via civetweb) after the new code sets PR_SET_DUMPABLE.
Add another prctl call before wait_shutdown.

Fixes: http://tracker.ceph.com/issues/19089

Signed-off-by: Brad Hubbard bhubbard@redhat.com

rgw: set dumpable flag after setuid post ff0e521
ff0e521 resolved the issue for the other daemons but not for rgw since
it calls setuid (via civetweb) after the new code sets PR_SET_DUMPABLE.
Add another prctl call before wait_shutdown.

Fixes: http://tracker.ceph.com/issues/19089

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

@badone badone requested a review from mattbenjamin Feb 27, 2017

@mattbenjamin

looks good

@badone badone merged commit f321309 into ceph:master Mar 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@badone badone deleted the badone:wip-rgw-setuid-no-coredump branch Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment