New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: use separate http_manager for read_sync_status #13660

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
2 participants
@shashalu
Contributor

shashalu commented Feb 27, 2017

concurrent users of read_sync_status() use different cr managers, when get_resource must
use http_manager related to the cr manager.

Signed-off-by: Shasha Lu lu.shasha@eisoo.com

@shashalu

This comment has been minimized.

Contributor

shashalu commented Feb 27, 2017

@cbodley
Hi, could you review this for me, thx

@cbodley

This comment has been minimized.

Contributor

cbodley commented Feb 27, 2017

@shashalu did this result in a crash?

@shashalu

This comment has been minimized.

Contributor

shashalu commented Feb 28, 2017

@cbodley
It won't crash. But when use radosgw-admin to init data sync, RGWCoroutinesManager::run will stuck after the first 100(RGW_ASYNC_OPS_MGR_WINDOW) RGWReadRemoteDataLogShardInfo requests sent.
The completion_mgr of RGWCoroutinesManager can't not get the completed req, because those reqs was sent by other http_manager.

@cbodley cbodley self-assigned this Feb 28, 2017

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 8, 2017

hi @shashalu, we'd like to backport this fix to jewel and kraken, so i opened a ticket at http://tracker.ceph.com/issues/19236. can you please add this to your commit message?

Fixes: http://tracker.ceph.com/issues/19236
rgw: use separate http_manager for read_sync_status
concurrent users of read_sync_status() use different cr managers, when get_resource must
use http_manager related to the cr manager.

Fixes: http://tracker.ceph.com/issues/19236

Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
@shashalu

This comment has been minimized.

Contributor

shashalu commented Mar 9, 2017

@cbodley ok, already updated.

@cbodley

cbodley approved these changes Mar 9, 2017

@cbodley cbodley merged commit 2bb96e0 into ceph:master Mar 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 9, 2017

thank you!

@shashalu shashalu deleted the shashalu:rgw-read-sync-status branch Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment