Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: pass through cluster log to plugins #13690

Merged
merged 1 commit into from Apr 1, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Copy link
Contributor

jcsp commented Feb 28, 2017

This is the simplest way -- no filtering on the C++ side, every python module gets notified of everything, and it's up to the python side to ignore it or do something with it

@jcsp jcsp added feature mgr labels Feb 28, 2017

John Spray
mgr: pass through cluster log to plugins
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp force-pushed the jcsp:wip-17503 branch from 9a338d9 to 9ea37c2 Mar 11, 2017

@gregsfortytwo

This comment has been minimized.

Copy link
Member

gregsfortytwo commented Mar 17, 2017

retest this please

@gregsfortytwo

This comment has been minimized.

Copy link
Member

gregsfortytwo commented Mar 17, 2017

This looks good to me (for what little that's worth when dealing with the Python runtime), but apparently it didn't build cleanly so need to figure out what that was about.

@@ -20,6 +20,7 @@
#include "Python.h"

#include "common/cmdparse.h"
#include "common/LogEntry.h"

This comment has been minimized.

Copy link
@tchaikov

tchaikov Mar 30, 2017

Contributor

nit, maybe we can just forward-declare LogEntry here.

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit 6ae3ce9 into ceph:master Apr 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.