New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: add override in headers #13691

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
5 participants
@Liuchang0812
Contributor

Liuchang0812 commented Feb 28, 2017

Signed-off-by: liuchang0812 liuchang0812@gmail.com

@liewegas liewegas added the cleanup label Feb 28, 2017

@tchaikov tchaikov added the cephfs label Mar 1, 2017

@batrick

This comment has been minimized.

Member

batrick commented Mar 2, 2017

Can you explain how you generated this patch?

@jcsp

This comment has been minimized.

Contributor

jcsp commented Mar 2, 2017

This has merge conflicts.

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 3, 2017

@batrick LLVM has a tool called clang-tidy, that it could do a lot of things base on semantic analyse. I use clang-tidy's clang-tidy -checks="-*, modernize-use-override" a.cpp -- -std=c++11 commond to add override automatically.

@jcsp Roger that, I will rebase it.

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 3, 2017

change log:

  1. rebased forward to master
@batrick

This comment has been minimized.

Member

batrick commented Mar 3, 2017

@Liuchang0812 thanks for explaining. Can you add a note about that to the commit message for posterity. Thanks.

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 3, 2017

@batrick roger that, I will add explaining to commit message soon

mds: add override in headers
LLVM has a tool called clang-tidy, that it could do a lot of things base on
semantic analyse.  We could use following command to add override automatically:
clang-tidy -checks="-*, modernize-use-override" a.cpp -- -std=c++11

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 3, 2017

change log:

  1. add note about clang-tidy in commit message
@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 6, 2017

@batrick @jcsp hi, would you mind taking a look?

@batrick

batrick approved these changes Mar 6, 2017

@batrick

This comment has been minimized.

Member

batrick commented Mar 6, 2017

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 8, 2017

@batrick @jcsp thanks. It would be better to merge it as soon as possible, because it contains a lot of changes and conflicts with other patches easily.

@jcsp jcsp merged commit 2a06ea3 into ceph:master Mar 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment