New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: add override in headers #13693

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
3 participants
@Liuchang0812
Contributor

Liuchang0812 commented Feb 28, 2017

No description provided.

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Feb 28, 2017

hi, jenkins test this please

@liewegas

This comment has been minimized.

Member

liewegas commented Feb 28, 2017

retest this please

@liewegas liewegas added the cleanup label Feb 28, 2017

@@ -66,8 +66,8 @@ class DataHealthService :
}
void get_health(Formatter *f,
list<pair<health_status_t,string> >& summary,
list<pair<health_status_t,string> > *detail) override;
list<pair<health_status_t,string> >& summary,

This comment has been minimized.

@tchaikov

tchaikov Feb 28, 2017

Contributor

please avoid format only changes.

This comment has been minimized.

@Liuchang0812

Liuchang0812 Feb 28, 2017

Contributor

Here's indentation problem, IMO, It would be better to do this format.

This comment has been minimized.

@tchaikov

tchaikov Feb 28, 2017

Contributor

@Liuchang0812 it renders the output of "git blame" less useful.

This comment has been minimized.

@Liuchang0812

Liuchang0812 Mar 1, 2017

Contributor

@tchaikov OK, I will revert the format commit. 😄

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 1, 2017

@tchaikov reverted the commit.

return service_dispatch_op(op);
}
virtual bool service_dispatch_op(MonOpRequestRef op) = 0;
public:
virtual void get_health(Formatter *f,
void get_health(Formatter *f,

This comment has been minimized.

@tchaikov

tchaikov Mar 1, 2017

Contributor

why not just remove these three declarations? @jecluis can we remove them?

This comment has been minimized.

@Liuchang0812

Liuchang0812 Mar 1, 2017

Contributor

IMO, there are unnecessary declarations.

mon: add override in headers
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 2, 2017

change log:

  1. rebase to master, fix the problem #13685

@liewegas liewegas merged commit d22b481 into ceph:master Mar 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@liewegas

This comment has been minimized.

Member

liewegas commented Mar 2, 2017

We can remove unnecessary decls in a subsequent PR

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 2, 2017

Thanks!

@Liuchang0812 Liuchang0812 deleted the Liuchang0812:wip-add-override-in-mon-headers branch Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment