New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: simplify image open/close semantics #13701

Merged
merged 4 commits into from Mar 2, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Feb 28, 2017

No description provided.

dillaman added some commits Feb 28, 2017

librbd: utilize a singleton ContextWQ instead of per-image instance
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: cleanup synchronous open/close memory management
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: eliminate context switch from remove state machine
Also cleaned up formatting issues within the state machine.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: eliminate context switch from close image state machine
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@trociny trociny self-assigned this Feb 28, 2017

static ThreadPool *get_thread_pool_instance(CephContext *cct);
static void get_thread_pool_instance(CephContext *cct,
ThreadPool **thread_pool,
ContextWQ **op_work_queue);

This comment has been minimized.

@trociny

trociny Mar 1, 2017

Contributor

@dillaman Looking at get_thread_pool_instance usage, why not crate a function that just returns work queue?

This comment has been minimized.

@dillaman

dillaman Mar 1, 2017

Contributor

Mainly because I had to combine the ContextWQ into ThreadPoolSingleton to be absolutely sure about construction/destruction ordering; wanted to keep the ThreadPoolSingleton private; and didn't want to have two functions that could potentially initialize the singleton.

@trociny

trociny approved these changes Mar 1, 2017

lgtm

@trociny

This comment has been minimized.

Contributor

trociny commented Mar 2, 2017

@ceph-jenkins retest this please

@trociny trociny merged commit a08af6c into ceph:master Mar 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-19010 branch Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment