New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: misc minor fixes #13713

Merged
merged 8 commits into from Mar 2, 2017

Conversation

Projects
None yet
2 participants
@drunkard
Contributor

drunkard commented Mar 1, 2017

No description provided.

drunkard added some commits Mar 1, 2017

doc: hyperlink fix
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
doc: remove dead doc from index
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
doc: command typo fix
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
performance degradation when users place large numbers of objects into a
bucket.
defaults to ``.rgw.buckets.index``. Sometimes, users like to put many objects
(hundreds of thousands to millions of objects) in a single bucket. If you did

This comment has been minimized.

@tchaikov

tchaikov Mar 1, 2017

Contributor

why s/do/did/?

This comment has been minimized.

@drunkard

drunkard Mar 1, 2017

Contributor

It should be "do", you are right.

(hundreds of thousands to millions of objects) in a single bucket. If you did
not set quotas for the maximum number of objects per bucket using the gateway
administration interface, the bucket index can suffer significant
performance degradation.

This comment has been minimized.

@tchaikov

tchaikov Mar 1, 2017

Contributor

i don't think "when users place large numbers of objects into a bucket" is redundant here. you could put

In this case, if you do not ....

to connect the precondition to its consequence.

@@ -321,7 +321,7 @@ For ``bind``, add a wildcard to the DNS record. For example::
* IN CNAME @
Restart your DNS server and ping your server with a subdomain to ensure that
your ``ceph-radosgw`` daemon can process the subdomain requests::
your DNS configuration works as expected::

This comment has been minimized.

@tchaikov

tchaikov Mar 1, 2017

Contributor

iiuc, the purpose of setting the DNS record is to enable radosgw to process the subdomain request. so the original doc also makes sense.

This comment has been minimized.

@drunkard

drunkard Mar 1, 2017

Contributor

ceph-radosgw is checked in section "Create a Gateway Instance", I think it's clerical mistake here.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 1, 2017

the "make check" failure is addressed by #13685

not set quotas for the maximum number of objects per bucket using the gateway
administration interface, the bucket index can suffer significant
performance degradation.
defaults to ``.rgw.buckets.index``. Sometimes users like to put many objects

This comment has been minimized.

@tchaikov

tchaikov Mar 1, 2017

Contributor

could you please just remove the commit being reverted?

drunkard added some commits Mar 1, 2017

doc: hyperlink typo fix in dev/index
The doc compiler complains about this.

Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
doc: fix aiming of command ping
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
doc: command typo fix, s/radosgw_admin/radosgw-admin
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
doc: add mark for quoted content
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
doc: add missed commas
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
@drunkard

This comment has been minimized.

Contributor

drunkard commented Mar 2, 2017

Improper commit removed according to advice of @tchaikov

@tchaikov tchaikov merged commit d34df31 into ceph:master Mar 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov self-assigned this Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment