New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: add --dump to crushtool #13726

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Mar 1, 2017

No description provided.

@ghost ghost added core documentation labels Mar 1, 2017

@ghost ghost requested review from tchaikov and liewegas Mar 1, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 1, 2017

Should we try to mirror the other ceph tools which do -f <json|json-pretty|xml|xml-pretty|plain> vs a different 'command' here? This could be '-d -f json-pretty'. (No strong opinion here; this is less consistent but probably an easier user experience.)

@ghost

This comment has been minimized.

ghost commented Mar 1, 2017

@liewegas I'll do that

@ghost

This comment has been minimized.

ghost commented Mar 1, 2017

@liewegas updated & repushed

@ghost ghost changed the title from crush: add --json to crushtool to crush: add --dump to crushtool Mar 1, 2017

@liewegas

This probably needs to be added to usage, and the cli test updated?

@ghost ghost added feature and removed documentation labels Mar 1, 2017

@ghost

This comment has been minimized.

ghost commented Mar 1, 2017

modified to update the usage and repushed

crush: add --dump to crushtool
So it can display the same as ceph osd crush dump from a file instead of
a live cluster. The default format is json-pretty and can be modified
via -f or --format in the same way as the ceph cli.

Signed-off-by: Loic Dachary <ldachary@redhat.com>

@yuriw yuriw merged commit f1bd9b9 into ceph:master Mar 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment