New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/OSDMap: don't set weight to IN when OSD is destroyed #13730

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
3 participants
@idryomov
Contributor

idryomov commented Mar 1, 2017

Since commit 4e28f9e ("osd/OSDMap: clear osd_info, osd_xinfo on
osd deletion"), weight is set to IN when OSD is deleted. This changes
the result of applying an incremental for clients, not just OSDs.
Because CRUSH computations are obviously affected, pre-4e28f9e63644
servers disagree with post-4e28f9e63644 clients on object placement,
resulting in misdirected requests.

Fixes: http://tracker.ceph.com/issues/19119
Signed-off-by: Ilya Dryomov idryomov@gmail.com

@idryomov

This comment has been minimized.

Contributor

idryomov commented Mar 1, 2017

After some discussion with @liewegas we've decided to go ahead with reverting the breakage and documenting how to avoid being bit on upgrades. This affects jewel, kraken and master.

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 1, 2017

Better to remove the line entirely and not touch the osd_weight because the OSD might have been marked in and setting it out will also change the mapping incompatibly with hammer and earlier.

@idryomov

This comment has been minimized.

Contributor

idryomov commented Mar 1, 2017

Yeah, I missed that we only check for down.

osd/OSDMap: don't set weight to IN when OSD is destroyed
Since commit 4e28f9e ("osd/OSDMap: clear osd_info, osd_xinfo on
osd deletion"), weight is set to IN when OSD is deleted.  This changes
the result of applying an incremental for clients, not just OSDs.
Because CRUSH computations are obviously affected, pre-4e28f9e63644
servers disagree with post-4e28f9e63644 clients on object placement,
resulting in misdirected requests.

Fixes: http://tracker.ceph.com/issues/19119
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Mar 1, 2017

I'll submit a separate set of PRs with release notes.

@yuriw yuriw merged commit 37ca392 into ceph:master Mar 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@idryomov idryomov deleted the idryomov:wip-osd-rm-incremental branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment