New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PendingReleaseNotes: warning about 'osd rm ...' and #19119 #13731

Merged
merged 1 commit into from May 17, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Mar 1, 2017

@jecluis

This comment has been minimized.

Member

jecluis commented Mar 2, 2017

Can't we force this in the monitor op?

AIUI, 'osd rm' semantics does imply losing the data anyway, so I don't think there's any gain by leaving the osd in the crushmap.

And forcing the user to run 'osd crush rm' followed by 'osd rm' just seems bad UX, besides being prone to error. We should, at least, check that the OSD has been removed from crush.

I will take upon myself getting that going if my rationale is correct/agreed upon.

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 2, 2017

@liewegas liewegas merged commit 752b838 into ceph:master May 17, 2017

0 of 3 checks passed

Signed-off-by checking if commits are signed
Details
Unmodifed Submodules Build triggered. sha1 is merged.
Details
default Build triggered. sha1 is merged.
Details

@liewegas liewegas deleted the liewegas:wip-19119 branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment