New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support blacklisting within librados_test_stub #13737

Merged
merged 7 commits into from Mar 10, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Mar 2, 2017

No description provided.

@dillaman dillaman added rbd tests labels Mar 2, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 2, 2017

Seeing sporadic test failures that need to be addressed

@dillaman dillaman changed the title from [DNM] test: support blacklisting within librados_test_stub to test: support blacklisting within librados_test_stub Mar 6, 2017

@trociny trociny self-assigned this Mar 7, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 8, 2017

retest this please

2 similar comments
@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 8, 2017

retest this please

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 9, 2017

retest this please

void LeaderWatcher<I>::acquire_leader_lock() {
return acquire_leader_lock(false);
if (m_acquire_attempts >
m_cct->_conf->rbd_mirror_leader_max_acquire_attempts_before_break) {

This comment has been minimized.

@trociny

trociny Mar 9, 2017

Contributor

@dillaman Shouldn't it be >=?
"max_acquire_attempts" suggests that we don't attempt more than this, while now we attempt one more time than this. TestLeaderWatcher.Break now runs for 40 sec instead of 30 (with the message "breaking leader lock after 4 failed attempts to acquire" in logs).

dillaman added some commits Mar 1, 2017

test/librados_test_stub: separate mock cluster from connection
The plan to support independent connections sharing the same
view of the mocked cluster.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
test/librados_test_stub: watch/notify should be connection-aware
Utilize the AIO completion thread of the local connection to best
simulate how librados actually performs when connected a cluster.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
test/librados_test_stub: support blacklisting of connections
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: avoid duplicating librados IoCtx objects if not needed
This introduces the potential for shutdown race conditions within
the unit tests.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
test: potential shutdown race in TestMockImageReplayer.DecodeError
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: improve debug log messages for managed lock
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: correct race conditions within leader watcher
It was possible for multiple, concurrent acquire attempts to be
running for a single instance due to notification messages. Now
only a single acquire state machine can be running.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 10, 2017

@trociny updated

@trociny

LGTM

@trociny

This comment has been minimized.

Contributor

trociny commented Mar 10, 2017

@ceph-jenkins retest this please

@trociny

This comment has been minimized.

Contributor

trociny commented Mar 10, 2017

Strangely, jenkins complains about "modified submodules found", though I don't see this in commits.
@ceph-jenkins retest this please

@trociny trociny merged commit 25c2482 into ceph:master Mar 10, 2017

2 of 3 checks passed

Unmodifed Submodules Approval needed: modified submodules found
Details
Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-19104 branch Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment