New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unittest_hostname compile error on freebsd #13739

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
4 participants
@Liuchang0812
Contributor

Liuchang0812 commented Mar 2, 2017

Signed-off-by: liuchang0812 liuchang0812@gmail.com

@wjwithagen I have no FreeBSD environment, mind taking a look? It's compiled successfully by clang. thanks!

#include <iostream>
#include <string>

This comment has been minimized.

@tchaikov

tchaikov Mar 2, 2017

Contributor

might want to remove #include <string>.

This comment has been minimized.

@Liuchang0812

Liuchang0812 Mar 2, 2017

Contributor

but std::string is used in line 35

This comment has been minimized.

@Liuchang0812

Liuchang0812 Mar 2, 2017

Contributor

oh, do you mean that I shouldn't reorder #include <string> ?

This comment has been minimized.

@tchaikov

tchaikov Mar 2, 2017

Contributor

it's duplicated with the #include at line:30

This comment has been minimized.

@Liuchang0812

Liuchang0812 Mar 2, 2017

Contributor

sorry. fixed it

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 2, 2017

../../lib/libceph-common.so.0: undefined reference to `boost::re_detail_106300::cpp_regex_traits_implementation<char>::transform[abi:cxx11](char const*, char const*) const'
../../lib/libceph-common.so.0: undefined reference to `boost::re_detail_106300::cpp_regex_traits_implementation<char>::transform_primary[abi:cxx11](char const*, char const*) const'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
src/test/CMakeFiles/unittest_xlist.dir/build.make:117: recipe for target 'bin/unittest_xlist' failed
make[2]: *** [bin/unittest_xlist] Error 1
CMakeFiles/Makefile2:7156: recipe for target 'src/test/CMakeFiles/unittest_xlist.dir/all' failed
make[1]: *** [src/test/CMakeFiles/unittest_xlist.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Seems that clang linker could not find boost::regex.

test: unittest_hostname compile error on freebsd
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>

@tchaikov tchaikov requested a review from wjwithagen Mar 2, 2017

@wjwithagen

Compile oke and executes on Clang/FreeBSD

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Mar 2, 2017

@wjwithagen thanks!

@tchaikov tchaikov added the needs-qa label Mar 2, 2017

@liewegas liewegas merged commit 50d215d into ceph:master Mar 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@Liuchang0812 Liuchang0812 deleted the Liuchang0812:fix-unittest-hostname branch Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment