New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: Update OSDMon.cc comments #13750

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
4 participants
@Saumay-Agrawal
Contributor

Saumay-Agrawal commented Mar 2, 2017

I have fixed the issue cleanup #19090: Wrong hard-coded URLs
I have replaced the wrong URLs with correct URLs redirecting to the Tunables headline under Crush Map documentation.
Please add it to the documentation.

Update OSDMon.cc
I have fixed the issue cleanup #19090: Wrong hard-coded URLs
I have replaced the wrong URLs with correct URLs redirecting to the Tunables headline under Crush Map documentation.
Please add it to the documentation.
@shinobu-x

This comment has been minimized.

Contributor

shinobu-x commented Mar 2, 2017

@Saumay-Agrawal I"m very sorry that I've not notice this one. You could squash this commit into another one 5fd2593

@liewegas liewegas changed the title from Update OSDMon.cc to mon: Update OSDMon.cc comments Mar 2, 2017

@liewegas liewegas merged commit 6aa4b76 into ceph:master Mar 2, 2017

2 of 3 checks passed

Signed-off-by one or more commits in this PR are not signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 24, 2017

next time, you need to prefix the title of your commit message with the subcomponent your are changing. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, and add a "Signed-off-by" line at the end of your commit message? "git commit -s" will do the trick for you. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#1-sign-your-work .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment