New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: relax "is parent mirrored" check when enabling mirroring for pool #13752

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
2 participants
@trociny
Contributor

trociny commented Mar 2, 2017

If the parent is in the same pool and has the journaling feature enabled
we can assume the mirroring will eventually be enabled for it.

Fixes: http://tracker.ceph.com/issues/19130
Signed-off-by: Mykola Golub mgolub@mirantis.com

@@ -218,7 +218,8 @@ namespace librbd {
int mirror_image_status_summary(IoCtx& io_ctx,
std::map<mirror_image_status_state_t, int> *states);
int mirror_image_enable(ImageCtx *ictx);
int mirror_image_enable(ImageCtx *ictx,
bool relax_same_pool_parent_check = false);

This comment has been minimized.

@dillaman

dillaman Mar 7, 2017

Contributor

Nit: avoid the default param

Mykola Golub
librbd: relax "is parent mirrored" check when enabling mirroring for …
…pool

If the parent is in the same pool and has the journaling feature enabled
we can assume the mirroring will eventually be enabled for it.

Fixes: http://tracker.ceph.com/issues/19130
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
@trociny

This comment has been minimized.

Contributor

trociny commented Mar 7, 2017

@dillaman updated

@dillaman

lgtm

@dillaman dillaman merged commit 5c26739 into ceph:master Mar 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@trociny trociny deleted the trociny:wip-19130 branch Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment