New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: allow 'osd objectstore = random' to pick either filestore or bluestore #13754

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Mar 2, 2017

No description provided.

@@ -66,6 +66,14 @@ ObjectStore *ObjectStore::create(CephContext *cct,
const string& journal,
osflagbits_t flags)
{
if (type == "random" &&

This comment has been minimized.

@tchaikov

tchaikov Mar 3, 2017

Contributor

might want to guard the if block with #if defined(HAVE_LIBAIO), otherwise the FreeBSD build is broken with this change. and since we always have libaio with our linux builds, it's safe to have this guard.

@yuriw

This comment has been minimized.

Contributor

yuriw commented Mar 6, 2017

passed testing awaiting review
@liewegas @tchaikov

@dillaman dillaman self-requested a review Mar 7, 2017

@yuriw yuriw removed the wip-yuri-testing label Mar 7, 2017

os/ObjectStore: allow 'random' to choose either filestore or bluestore
Useful for testing.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Mar 27, 2017

@tchaikov ping

@tchaikov tchaikov added needs-qa and removed needs-qa labels Mar 27, 2017

@tchaikov tchaikov merged commit 52468ae into ceph:master Mar 27, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 27, 2017

as it has been tested by yuri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment