os: allow 'osd objectstore = random' to pick either filestore or bluestore #13754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Mar 3, 2017
src/os/ObjectStore.cc
Outdated
| @@ -66,6 +66,14 @@ ObjectStore *ObjectStore::create(CephContext *cct, | |||
| const string& journal, | |||
| osflagbits_t flags) | |||
| { | |||
| if (type == "random" && | |||
There was a problem hiding this comment.
might want to guard the if block with #if defined(HAVE_LIBAIO), otherwise the FreeBSD build is broken with this change. and since we always have libaio with our linux builds, it's safe to have this guard.
Useful for testing. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-objectstore-random
branch
from
b8defc1
to
0653559
Compare
|
@tchaikov ping |
tchaikov
approved these changes
Mar 27, 2017
|
as it has been tested by yuri. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.