New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/osd_internal_types: wake snaptrimmer on put_read lock, too #13755

Merged
merged 2 commits into from Mar 6, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Mar 2, 2017

The snaptrimmer can block taking a write lock, which might happen due to
a conficting EC read. When the EC read completes, we need to wake up the
snaptrimmer.

Fixes: http://tracker.ceph.com/issues/19131
Signed-off-by: Sage Weil sage@redhat.com

osd/osd_internal_types: wake snaptrimmer on put_read lock, too
The snaptrimmer can block taking a write lock, which might happen due to
a conficting EC read.  When the EC read completes, we need to wake up the
snaptrimmer.

Fixes: http://tracker.ceph.com/issues/19131
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from jdurgin Mar 2, 2017

qa/suites/rados/thrash: add no-thrash item to matrix
Run all of our cases with no thrashing.  This would have uncovered
http://tracker.ceph.com/issues/19131 much sooner!

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Mar 6, 2017

looks ok in my test run

@jdurgin

jdurgin approved these changes Mar 6, 2017

@jdurgin jdurgin merged commit 3580d22 into ceph:master Mar 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment