New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_file: posix style atime,ctime,mtime #13765

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
2 participants
@guihecheng
Contributor

guihecheng commented Mar 3, 2017

As an ganesha FSAL backend, rgw_file should properly maintain
the atime,ctime,mtime properly against operations such as:
(read,write) for file
(create,unlink,mkdir,rmdir,rename) for dir
(setattr) for file and dir

Signed-off-by: Gui Hecheng guihecheng@cmss.chinamobile.com

Gui Hecheng
rgw_file: posix style atime,ctime,mtime
As an ganesha FSAL backend, rgw_file should properly maintain
the atime,ctime,mtime properly against operations such as:
	(read,write) for file
	(create,unlink,mkdir,rmdir,rename) for dir
	(setattr) for file and dir

Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>
@mattbenjamin

I think conceptually this is good as written; an implication that this change current avoids--but which someone reading it might infer?--is that these strict time updates aren't propagating through the cluster, unless a client sends a SETATTR, so time runs differently on different nfs servers, and could run backwards in a failure; I don't want to (have to) pay the extra i/o cost of preventing that; it would be fine to do it conditionally if someone does want it

@mattbenjamin mattbenjamin merged commit 8786b4c into ceph:master Mar 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@guihecheng

This comment has been minimized.

Contributor

guihecheng commented Mar 7, 2017

@mattbenjamin oh, sorry to reply late, what you said is right, persistency work shall be done if (only if) we really need it.

@guihecheng guihecheng deleted the guihecheng:rgwfs-time-attrs branch Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment