New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librados, osd: clang fixes #13768

Merged
merged 2 commits into from Mar 7, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Mar 3, 2017

No description provided.

librados: rados_inconsistent_pg_list() check "buf" param for null bef…
…ore copying to it

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the cleanup label Mar 3, 2017

@tchaikov tchaikov requested a review from badone Mar 3, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 3, 2017

@badone

This comment has been minimized.

Contributor

badone commented Mar 3, 2017

Please test this

@badone

This appears to break PGLog::read_log_and_missing as the compiler can't find a suitable overload

bool *clear_divergent_priors,
const DoutPrefixProvider *dpp,
set<string> *log_keys_debug,
bool debug_verify_stored_missing
) {

This comment has been minimized.

@badone

badone Mar 3, 2017

Contributor

The call site at ceph_objectstore_tool.cc:331 (there may be others) relies on the defaults being set.

osd/PGLog: always use ldpp_dout() to print with dpp
lderr(dpp->get_cct()) could crash if dpp is null.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 3, 2017

@badone fixed & repushed

@badone

badone approved these changes Mar 3, 2017

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit bdc22af into ceph:master Mar 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-clang-fixes branch Mar 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment