New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: make package groups comply with openSUSE guidelines #13781

Merged
merged 2 commits into from Mar 13, 2017

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Mar 3, 2017

. . . and put all Group: lines in SUSE conditional blocks.

Fixes: http://tracker.ceph.com/issues/19184
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 3, 2017

pushed wip-19184 to Shaman

@ktdreyer

Thanks

@b-ranto

Few comments:

Isn't there any better group than System/Filesystems for the basic stuff? The only thing that is actually a file system is cephfs. The rest would probably better satisfy a definition of a DB.

Why are we dropping the groups for non-suse versions altogether? I suppose, the non-marked-by-group packages will inherit the group from the main package (not sure, here, just guessing) but this will put all the libraries, devel files, ... into the System/Filesystems group on RH platforms.

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Mar 3, 2017

Fedora's guidelines say "The BuildRoot: tag, Group: tag, and %clean section SHOULD NOT be used."

Groups are defined in Fedora's comps now.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 3, 2017

@b-ranto: The idea here is to completely eliminate the Group: tag for non-SUSE platforms for all RPMs. Before this patch, this was done for the main package but not for the subpackages.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 3, 2017

Changelog:

  • clarified the comments ("common" was misleading - change to "main package" and "subpackages")
  • change several instances of System/Libraries to System/Libraries/C and C++ for consistency

Also re-pushed to Shaman.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 3, 2017

@b-ranto I went through it again and verified that this patch puts all Group: lines (i.e. including the one for the main package) in SUSE conditionals.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 3, 2017

Isn't there any better group than System/Filesystems for the basic stuff?

The short answer to this question is "no".

@dmick

I mean, if it's right, it's right; seems to me these groups are of next to no utility, and it's all conditional for SUSE, so...

@b-ranto

b-ranto approved these changes Mar 4, 2017

@b-ranto

This comment has been minimized.

Contributor

b-ranto commented Mar 4, 2017

You are right, it is all suse-specific. I did not notice the first conditional because it was not a part of the change.

@smithfarm smithfarm changed the title from build/ops: make package groups comply with openSUSE guidelines to [DNM] build/ops: make package groups comply with openSUSE guidelines Mar 4, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 4, 2017

Passes Shaman, but will wait to hear what the openSUSE:Factory reviewer has to say before merging it.

smithfarm added some commits Mar 3, 2017

build/ops: make package groups comply with openSUSE guidelines
. . . and put all Group: lines in SUSE conditional blocks.

Fixes: http://tracker.ceph.com/issues/19184
Signed-off-by: Nathan Cutler <ncutler@suse.com>
build/ops: extend rpm spec file copyright period to 2017
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 10, 2017

Rebased, changed System/Libraries/C and C++ and System/Libraries/Java to just System/Libraries. Now waiting on second round of openSUSE review.

@smithfarm smithfarm changed the title from [DNM] build/ops: make package groups comply with openSUSE guidelines to build/ops: make package groups comply with openSUSE guidelines Mar 13, 2017

@smithfarm smithfarm merged commit 0c2f5f7 into ceph:master Mar 13, 2017

2 of 3 checks passed

Unmodifed Submodules Approval needed: modified submodules found
Details
Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details

@smithfarm smithfarm deleted the SUSE:wip-19184 branch Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment