New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: remove \n on clog messages #13794

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Mar 4, 2017

Confirmed these aren't needed, and are inconsistently included.
Remove them where they do appear.

Signed-off-by: Sage Weil sage@redhat.com

@@ -2345,7 +2345,7 @@ CInode* Server::prepare_new_inode(MDRequestRef& mdr, CDir *dir, inodeno_t useino
dout(0) << "WARNING: client specified " << useino << " and i allocated " << in->inode.ino << dendl;
mds->clog->error() << mdr->client_request->get_source()
<< " specified ino " << useino
<< " but mds." << mds->get_nodeid() << " allocated " << in->inode.ino << "\n";
<< " but mds." << mds->get_nodeid() << " allocated " << in->inode.ino << "";

This comment has been minimized.

@badone

badone Mar 5, 2017

Contributor

Can we get rid of ' << ""' here? What purpose does it serve?

This comment has been minimized.

@liewegas

liewegas Mar 6, 2017

Member

good catch, fixed!

common: remove \n on clog messages
Confirmed these aren't needed, and are inconsistently included.
Remove them where they do appear.

Signed-off-by: Sage Weil <sage@redhat.com>
@badone

badone approved these changes Mar 6, 2017

@tchaikov tchaikov merged commit 8955613 into ceph:master Mar 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@tchaikov

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment