New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluestore, NVMEDEVICE: Specify the max io completion in conf #13799

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@optimistyzy
Contributor

optimistyzy commented Mar 6, 2017

I do not think that 4 is meaninful. If a value needs to be determined,
it should be configured in the configuration file.

Signed-off-by: optimistyzy optimistyzy@gmail.com

@optimistyzy

This comment has been minimized.

Show comment
Hide comment
@optimistyzy
Contributor

optimistyzy commented Mar 6, 2017

bluestore, NVMEDEVICE: Specify the max io completion in conf
I do not think that 4 is meaninful. If a value needs to be determined,
it should be configured in the configuration file.

Signed-off-by: optimistyzy <optimistyzy@gmail.com>
@liupan1111

This comment has been minimized.

Show comment
Hide comment
@liupan1111

liupan1111 Mar 6, 2017

Contributor

@optimistyzy , the default value is 0??

Contributor

liupan1111 commented Mar 6, 2017

@optimistyzy , the default value is 0??

@optimistyzy

This comment has been minimized.

Show comment
Hide comment
@optimistyzy

optimistyzy Mar 6, 2017

Contributor

@liupan1111. Yes, default is 0. It means that let SPDK determine the max io completion number.

Contributor

optimistyzy commented Mar 6, 2017

@liupan1111. Yes, default is 0. It means that let SPDK determine the max io completion number.

@liupan1111

This comment has been minimized.

Show comment
Hide comment
@liupan1111

liupan1111 Mar 6, 2017

Contributor

@optimistyzy I prefer you add a comment for this default 0... users maybe puzzled..

Contributor

liupan1111 commented Mar 6, 2017

@optimistyzy I prefer you add a comment for this default 0... users maybe puzzled..

@optimistyzy

This comment has been minimized.

Show comment
Hide comment
@optimistyzy
Contributor

optimistyzy commented Mar 6, 2017

@liupan1111 liupan1111 added the bluestore label Mar 6, 2017

@optimistyzy

This comment has been minimized.

Show comment
Hide comment
@optimistyzy

optimistyzy Mar 7, 2017

Contributor

@liupan1111 @yuyuyu101 Can this patch be merged?

Contributor

optimistyzy commented Mar 7, 2017

@liupan1111 @yuyuyu101 Can this patch be merged?

@yuyuyu101 yuyuyu101 merged commit 53b4cec into ceph:master Mar 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment