New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/librbd: move tests using non-public api to internal #13806

Merged
merged 2 commits into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@vshankar
Contributor

vshankar commented Mar 6, 2017

moved TestCoR and FlattenNoEmptyObjects to internal tests.

vshankar added some commits Mar 5, 2017

test / librbd: create_image_full_pp() / clone_image_pp() helpers
Signed-off-by: Venky Shankar <vshankar@redhat.com>
test / librbd: move non-public api usage tests to internal
Signed-off-by: Venky Shankar <vshankar@redhat.com>
@@ -22,6 +22,33 @@ bool is_feature_enabled(uint64_t feature) {
return (get_features(&features) && (features & feature) == feature);
}
int create_image_full_pp(librbd::RBD &rbd, librados::IoCtx &ioctx,

This comment has been minimized.

@vshankar

vshankar Mar 6, 2017

Contributor

create_image_pp() below is not changed to use this helper as DiffIterateTest/1.DiffIterate test case fails with stripingv2 image.

Will fix that as part of a separate pr.

ASSERT_EQ(0, m_rbd.open(m_ioctx, image, clonename.c_str(), NULL));
ASSERT_EQ(0, image.stat(info, sizeof(info)));
ASSERT_EQ(0, rados_nobjects_list_open(d_ioctx, &list_ctx));

This comment has been minimized.

@vshankar

vshankar Mar 6, 2017

Contributor

Ideally we'd use nobejcts_begin(), nobjects_end() and get_next() methods from librados::IoCtx, but it seems like these methods are not implemented in librados test stub.

@vshankar vshankar requested review from trociny and dillaman Mar 6, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 6, 2017

retest this please

@trociny

trociny approved these changes Mar 6, 2017

LGTM

@dillaman dillaman changed the title from move tests using non-public api to internal to test/librbd: move tests using non-public api to internal Mar 6, 2017

@dillaman

lgtm

@dillaman dillaman merged commit 91ae4cd into ceph:master Mar 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@dillaman

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment