New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: try to avoid false positive heartbeat timeouts #13807

Merged
merged 2 commits into from Mar 15, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Contributor

jcsp commented Mar 6, 2017

mds: heartbeat_reset in dispatch
Previously we only heartbeated in tick.  However, our locking is
not guaranteed to be fair, so on a super-busy dispatch queue it may be
possible for the heartbeat to time out while the tick() function
is waiting for mds_lock.

Fixes: http://tracker.ceph.com/issues/19118
Signed-off-by: John Spray <john.spray@redhat.com>
mds: reset heartbeat in export_remaining_imported_caps
This loop can be very long.

Fixes: http://tracker.ceph.com/issues/19118
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp requested a review from ukernel Mar 8, 2017

@jcsp

This comment has been minimized.

Contributor

jcsp commented Mar 8, 2017

This passed fs suite on branch wip-jcsp-testing-20170307

@jcsp jcsp merged commit 5f6fa0e into ceph:master Mar 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-19118 branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment