New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: spell out image features unsupported by the kernel #13812

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Projects
None yet
3 participants
@idryomov
Contributor

idryomov commented Mar 6, 2017

/sys/bus/rbd/supported_features is available on kernels starting with
4.11. Example output:

$ sudo rbd map x
rbd: sysfs write failed
RBD image feature set mismatch. This image cannot be mapped because the following immutable features are unsupported by the kernel: data-pool.
In some cases useful info is found in syslog - try "dmesg | tail" or so.
rbd: map failed: (6) No such device or address

$ sudo rbd map -p foo y
rbd: sysfs write failed
RBD image feature set mismatch. You can disable features unsupported by the kernel with "rbd feature disable foo/y object-map fast-diff deep-flatten".
In some cases useful info is found in syslog - try "dmesg | tail" or so.
rbd: map failed: (6) No such device or address

or, if /sys/bus/rbd/supported_features isn't there:

$ sudo rbd map z
rbd: sysfs write failed
RBD image feature set mismatch. Try disabling features unsupported by the kernel with "rbd feature disable".
In some cases useful info is found in syslog - try "dmesg | tail" or so.
rbd: map failed: (6) No such device or address

Fixes: http://tracker.ceph.com/issues/19095
Signed-off-by: Ilya Dryomov idryomov@gmail.com

@idryomov

This comment has been minimized.

Contributor

idryomov commented Mar 6, 2017

The kernel patch has to go in first.

@idryomov

This comment has been minimized.

Contributor

idryomov commented Mar 6, 2017

retest this please

@shinobu-x

This comment has been minimized.

Contributor

shinobu-x commented Mar 8, 2017

LGTM

@dillaman

lgtm. While you are in here -- can you drop the " or so" portion of the 'try "dmesg | tail" or so' message?

@idryomov

This comment has been minimized.

Contributor

idryomov commented Mar 9, 2017

@dillaman I think that's a verbatim copy from mount(8), which means it's at least a dozen years old. Is there something wrong with it?

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 9, 2017

@idryomov It just reads like a non-native English speaker wrote that clause. The best I can figure is that perhaps the goal was to say "or similar". It's just a trivial thing that bugs me every time I see a user paste that error message in a message or IRC chat. Not that big of a deal, just a suggestion to clean it up.

rbd: spell out image features unsupported by the kernel
/sys/bus/rbd/supported_features is available on kernels starting with
4.11.  Example output:

    $ sudo rbd map x
    rbd: sysfs write failed
    RBD image feature set mismatch. This image cannot be mapped because the following immutable features are unsupported by the kernel: data-pool.
    In some cases useful info is found in syslog - try "dmesg | tail".
    rbd: map failed: (6) No such device or address

    $ sudo rbd map -p foo y
    rbd: sysfs write failed
    RBD image feature set mismatch. You can disable features unsupported by the kernel with "rbd feature disable foo/y object-map fast-diff deep-flatten".
    In some cases useful info is found in syslog - try "dmesg | tail".
    rbd: map failed: (6) No such device or address

or, if /sys/bus/rbd/supported_features isn't there:

    $ sudo rbd map z
    rbd: sysfs write failed
    RBD image feature set mismatch. Try disabling features unsupported by the kernel with "rbd feature disable".
    In some cases useful info is found in syslog - try "dmesg | tail".
    rbd: map failed: (6) No such device or address

Fixes: http://tracker.ceph.com/issues/19095
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

@idryomov idryomov changed the title from [DNM] rbd: spell out image features unsupported by the kernel to rbd: spell out image features unsupported by the kernel Mar 10, 2017

@idryomov

This comment has been minimized.

Contributor

idryomov commented Mar 10, 2017

Dropped " or so" and took off DNM.

@dillaman

lgtm

@idryomov idryomov merged commit aa647f4 into ceph:master Mar 14, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@idryomov idryomov deleted the idryomov:wip-krbd-feature-disable-msg branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment