New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rados: allow "rados purge" to delete objects when osd is full #13814

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
4 participants
@liupan1111
Contributor

liupan1111 commented Mar 6, 2017

Signed-off-by: Pan Liu liupan1111@gmail.com

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 6, 2017

@ceph-jenkins retest this please.

@liupan1111 liupan1111 requested a review from dillaman Mar 6, 2017

@@ -2855,6 +2855,7 @@ static int rados_tool_common(const std::map < std::string, std::string > &opts,
goto out;
}
io_ctx.set_namespace(all_nspaces);
io_ctx.set_osdmap_full_try();

This comment has been minimized.

@dillaman

dillaman Mar 7, 2017

Contributor

Nit: indentation looks incorrect

This comment has been minimized.

@liupan1111

liupan1111 Mar 7, 2017

Contributor

@dillaman done, thanks.

rados: allow "rados purge" to delete objects when osd is full
Signed-off-by: Pan Liu <liupan1111@gmail.com>
@dillaman

lgtm

@dillaman dillaman added the needs-qa label Mar 7, 2017

@@ -2855,6 +2855,7 @@ static int rados_tool_common(const std::map < std::string, std::string > &opts,
goto out;
}
io_ctx.set_namespace(all_nspaces);
io_ctx.set_osdmap_full_try();

This comment has been minimized.

@dzafman

dzafman Mar 7, 2017

Member

I think we should consider supporting the --force-full option just like the "rm" object command does.

This comment has been minimized.

@dzafman

dzafman Mar 7, 2017

Member

Unfortunately, from what I can see using aio_remove() can only use set_osdmap_full_try(), so for now I withdraw my suggestion to support --force-full unless/until another option is added to set that in the io_ctx.

@tchaikov tchaikov merged commit a838f20 into ceph:master Mar 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liupan1111 liupan1111 deleted the liupan1111:wip-fix-remove-when-full branch Mar 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment