New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vstart: add --help documentation for rgw_num #13817

Merged
merged 1 commit into from Mar 15, 2017

Conversation

Projects
None yet
5 participants
@alimaredia
Contributor

alimaredia commented Mar 6, 2017

Signed-off-by: Ali Maredia amaredia@redhat.com

@alimaredia

This comment has been minimized.

Contributor

alimaredia commented Mar 6, 2017

Should I do the same for ceph-mgr?

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 6, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 7, 2017

[ RUN      ] TestImageReplayer.Resync
...
Total Test time (real) = 4123.33 sec

The following tests FAILED:
	162 - unittest_rbd_mirror (Timeout)
Errors while running CTest

https://jenkins.ceph.com/job/ceph-pull-requests/19683/console

retest this please.

@alimaredia

This comment has been minimized.

Contributor

alimaredia commented Mar 7, 2017

I added some more changes to the usage. Let me know what you think.

@alimaredia

This comment has been minimized.

Contributor

alimaredia commented Mar 14, 2017

@tchaikov can we merge this soon?

@@ -126,9 +126,14 @@ usage=$usage"\t-X disable cephx\n"
usage=$usage"\t--hitset <pool> <hit_set_type>: enable hitset tracking\n"
usage=$usage"\t-e : create an erasure pool\n";
usage=$usage"\t-o config\t\t add extra config parameters to all sections\n"
usage=$usage"\tmon : start just ceph monitor's\n"
usage=$usage"\tosd : start just ceph osd's\n"
usage=$usage"\tmds : start just ceph mds's\n"

This comment has been minimized.

@cbodley

cbodley Mar 14, 2017

Contributor

the plurals shouldn't have ' in them (and the plural of 'mds' is 'mdses' according to @adamemerson)

vstart: --help usage for rgw_num, mgr_num, mon, mds, osd
Signed-off-by: Ali Maredia <amaredia@redhat.com>
@@ -126,9 +126,14 @@ usage=$usage"\t-X disable cephx\n"
usage=$usage"\t--hitset <pool> <hit_set_type>: enable hitset tracking\n"
usage=$usage"\t-e : create an erasure pool\n";
usage=$usage"\t-o config\t\t add extra config parameters to all sections\n"
usage=$usage"\tmon : start just ceph MONs\n"
usage=$usage"\tosd : start just ceph OSDs\n"
usage=$usage"\tmds : start just ceph MDSes\n"

This comment has been minimized.

@tchaikov

tchaikov Mar 15, 2017

Contributor

this is not true anymore, because mgr is always started.

This comment has been minimized.

@tchaikov

tchaikov Mar 15, 2017

Contributor

okay, i just pulled together a fix at #13974

@tchaikov tchaikov merged commit bd7146e into master Mar 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the wip-vstart-rgw-help branch Mar 15, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 15, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 15, 2017

@liewegas which means if MDS=0 no MDS will be started? and if none of {MDS|MGR|OSD|MON} is found in env vars, all of them will be started, right? but if any of them is specified, only the specified ones will be started.

@alimaredia

This comment has been minimized.

Contributor

alimaredia commented Mar 15, 2017

Yeah, I thought about adding an example of starting the daemons with env vars to the usage but didn't want to confuse new people who'll read the usage for the first time.

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment