New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: cleanup lifecycle managament #13820

Merged
merged 7 commits into from Mar 20, 2017

Conversation

Projects
None yet
3 participants
@mikulely
Contributor

mikulely commented Mar 7, 2017

Jenkins test passed. @yehudasa @cbodley @dang would u mind take a look? Thx.

@mikulely mikulely changed the title from Cleanup rgw lc to rgw: cleanup lifecycle managament Mar 7, 2017

rgw: cleanup err log msg in RGWDeletePut Op
Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
@@ -1445,8 +1445,6 @@ OPTION(rgw_port, OPT_STR, "") // port to listen, format as "8080" "5000", if no
OPTION(rgw_dns_name, OPT_STR, "") // hostname suffix on buckets
OPTION(rgw_dns_s3website_name, OPT_STR, "") // hostname suffix on buckets for s3-website endpoint
OPTION(rgw_content_length_compat, OPT_BOOL, false) // Check both HTTP_CONTENT_LENGTH and CONTENT_LENGTH in fcgi env
OPTION(rgw_lifecycle_enabled, OPT_BOOL, true) //rgw lifecycle enabled

This comment has been minimized.

@cbodley

cbodley Mar 15, 2017

Contributor

thanks for pointing this out! i think we should probably implement this one, instead of removing it

This comment has been minimized.

@mikulely

mikulely Mar 15, 2017

Contributor

hi @cbodley rgw_lifecycle_enabled is redundant with rgw_enable_lc_threads ,which is wildly used.

mikulely added some commits Mar 7, 2017

rgw: fix RGWGetLC Op capacity from write to read
Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
rgw: cleanup RGWPutLC::execute log msg
Format it same as "New LifecycleConfiguration:" to simplify log parsing.

Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
rgw: remove unnecessary file include
Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
@cbodley

looks good. the changes to lifecycle config variables pointed out that we're lacking a bit in documentation. i created a tracker issue for lifecycle docs at http://tracker.ceph.com/issues/19280

@mikulely

This comment has been minimized.

Contributor

mikulely commented Mar 16, 2017

retest this please

mikulely added some commits Mar 15, 2017

rgw: cleanup redundant file include for lc
Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
rgw: kill dead lc config options
+ rgw_lifecycle_enabled is redundant with rgw_enable_lc_threads,which is
  wildly used.
+ rgw_lifecycle_thread is never used.

Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
doc: fix typos in common/config_opts.h comments
Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>

@cbodley cbodley merged commit 0afb438 into ceph:master Mar 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment