New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/Stack.cc: use of pthread_setname_np() needs compat.h #13825

Merged
merged 1 commit into from Mar 13, 2017

Conversation

Projects
None yet
4 participants
@wjwithagen
Contributor

wjwithagen commented Mar 7, 2017

  • Because there is a name decrepancy between FreeBSD and Linux
    Which is repaired in compat.h

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@yuyuyu101 yuyuyu101 added the core label Mar 7, 2017

@wjwithagen wjwithagen changed the title from msg/async/Stack.cc: use of pthread_setname_np() needs compat.h to DNM: msg/async/Stack.cc: use of pthread_setname_np() needs compat.h Mar 7, 2017

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Mar 7, 2017

This still fails on FreeBSD, so something else is definitly wrong in patching up all the non-posix stuff here.

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Mar 7, 2017

@yuyuyu101
For this to work Stack.cc needs to us: ceph_pthread_setname()
Which is then mapped to the different flavours of pthread*set*name*()

@yuyuyu101

This comment has been minimized.

Member

yuyuyu101 commented Mar 7, 2017

@wjwithagen looks better to me

msg/async/Stack.cc: use of pthread_setname_np() needs compat.h
 - use Ceph abstraction for pthread_setname_np
 - Because there is a name decrepancy between FreeBSD and Linux
   Which is repaired in compat.h

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Mar 7, 2017

@yuyuyu101
Lets see if it builds....
I'm also running a FreeBSD/Jenkins run.
http://cephdev.digiware.nl:8180/jenkins/job/ceph-master/384/console

@wjwithagen wjwithagen changed the title from DNM: msg/async/Stack.cc: use of pthread_setname_np() needs compat.h to msg/async/Stack.cc: use of pthread_setname_np() needs compat.h Mar 7, 2017

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Mar 7, 2017

@yuyuyu101
My jenkins fails due to again another change unrelated to this.
But building is oke.

@tchaikov tchaikov added the needs-qa label Mar 7, 2017

@yuriw yuriw merged commit 8a76c88 into ceph:master Mar 13, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-stack-compat branch Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment