Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/MonClient: don't return zero global_id #13853

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Copy link
Contributor

tchaikov commented Mar 8, 2017

active_con is reset after re-connecting. get_global_id() return 0
before mon client receives the MAuthReply. The zero global_id
confuses mds code. in this change, MonClient promote the active_con's
global_id to this->global_id once it's authorized. and returns
this->global_id in get_global_id().

Fixes: http://tracker.ceph.com/issues/19134
Signed-off-by: "Yan, Zheng" zyan@redhat.com
Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Mar 8, 2017

retest this please.

mon/MonClient: don't return zero global_id
active_con is reset after re-connecting. get_global_id() return 0
before mon client receives the MAuthReply. The zero global_id
confuses mds code. in this change, MonClient promote the active_con's
global_id to this->global_id once it's authorized. and returns
this->global_id in get_global_id().

Fixes: http://tracker.ceph.com/issues/19134
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-19134 branch from 2b6f8c8 to 7f964fe Mar 10, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Mar 10, 2017

rebased against master.

@tchaikov tchaikov added the needs-qa label Mar 10, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Mar 10, 2017

@alfredodeza i swear that i am not modifying any submodule in this PR =)

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Mar 10, 2017

@tchaikov because of the rebase, the test was already triggered with a sha1 that didn't exist, so the script failed. It should probably guard against that

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Mar 10, 2017

retest this please.

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Mar 10, 2017

@alfredodeza actually quite a few PRs' "submodule" check failed.

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Mar 17, 2017

retest this please

@tchaikov tchaikov merged commit cb6ab91 into ceph:master Mar 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-19134 branch Mar 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.